diff --git a/pkg/gitlab/gitlab.go b/pkg/gitlab/gitlab.go index 89ee5b37587df1eae1fa7ddf3c166a04ba901229..c9f83244942c34a689e2e6f03108ce10c3198d0b 100644 --- a/pkg/gitlab/gitlab.go +++ b/pkg/gitlab/gitlab.go @@ -252,10 +252,7 @@ func (g *Gitlab) CreateIssue(msg *alertmanager.Webhook) error { } } // Try to create a new issue rather than discarding it after failed update. - if err := g.createGitlabIssue(msg, groupingLabels, issueText); err != nil { - return err - } - return nil + return g.createGitlabIssue(msg, groupingLabels, issueText) } func (g *Gitlab) ping() error { diff --git a/pkg/prober/prober.go b/pkg/prober/prober.go index 56f8f525dc762656c64f4f584af5479f13103605..39e7841a394760ff558d6de3c1a8509b6443054f 100644 --- a/pkg/prober/prober.go +++ b/pkg/prober/prober.go @@ -44,7 +44,7 @@ func (p *Prober) registerInRouter(router *mux.Router) { router.HandleFunc("/readiness", p.readinessHandler) } -func (p *Prober) livenessHandler(w http.ResponseWriter, r *http.Request) { +func (p *Prober) livenessHandler(w http.ResponseWriter, _ *http.Request) { w.WriteHeader(http.StatusOK) _, _ = io.WriteString(w, `OK`) } @@ -54,7 +54,7 @@ func (p *Prober) writeFailedReadiness(w http.ResponseWriter, err error) { http.Error(w, err.Error(), http.StatusServiceUnavailable) } -func (p *Prober) readinessHandler(w http.ResponseWriter, r *http.Request) { +func (p *Prober) readinessHandler(w http.ResponseWriter, _ *http.Request) { if err := p.isReady(); err != nil { p.writeFailedReadiness(w, err) return