From 12898bf3cdeb4fc9012392e121264b3836a1290a Mon Sep 17 00:00:00 2001
From: Martin Chodur <m.chodur@seznam.cz>
Date: Fri, 28 Apr 2023 23:55:46 +0200
Subject: [PATCH] fix: lint
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
---
pkg/gitlab/gitlab.go | 5 +----
pkg/prober/prober.go | 4 ++--
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/pkg/gitlab/gitlab.go b/pkg/gitlab/gitlab.go
index 89ee5b3..c9f8324 100644
--- a/pkg/gitlab/gitlab.go
+++ b/pkg/gitlab/gitlab.go
@@ -252,10 +252,7 @@ func (g *Gitlab) CreateIssue(msg *alertmanager.Webhook) error {
}
}
// Try to create a new issue rather than discarding it after failed update.
- if err := g.createGitlabIssue(msg, groupingLabels, issueText); err != nil {
- return err
- }
- return nil
+ return g.createGitlabIssue(msg, groupingLabels, issueText)
}
func (g *Gitlab) ping() error {
diff --git a/pkg/prober/prober.go b/pkg/prober/prober.go
index 56f8f52..39e7841 100644
--- a/pkg/prober/prober.go
+++ b/pkg/prober/prober.go
@@ -44,7 +44,7 @@ func (p *Prober) registerInRouter(router *mux.Router) {
router.HandleFunc("/readiness", p.readinessHandler)
}
-func (p *Prober) livenessHandler(w http.ResponseWriter, r *http.Request) {
+func (p *Prober) livenessHandler(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
_, _ = io.WriteString(w, `OK`)
}
@@ -54,7 +54,7 @@ func (p *Prober) writeFailedReadiness(w http.ResponseWriter, err error) {
http.Error(w, err.Error(), http.StatusServiceUnavailable)
}
-func (p *Prober) readinessHandler(w http.ResponseWriter, r *http.Request) {
+func (p *Prober) readinessHandler(w http.ResponseWriter, _ *http.Request) {
if err := p.isReady(); err != nil {
p.writeFailedReadiness(w, err)
return
--
GitLab