From ac9d88e5a23203cd3abc09f0d15b756c726525ab Mon Sep 17 00:00:00 2001
From: Senan Kelly <senan@senan.xyz>
Date: Fri, 24 Mar 2023 00:26:07 +0000
Subject: [PATCH] Only warn about missing docker network when network_mode is
not host or container
---
pkg/provider/docker/config.go | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/pkg/provider/docker/config.go b/pkg/provider/docker/config.go
index 75110d095..894bb1049 100644
--- a/pkg/provider/docker/config.go
+++ b/pkg/provider/docker/config.go
@@ -310,6 +310,7 @@ func (p *Provider) getIPPort(ctx context.Context, container dockerData, serverPo
func (p Provider) getIPAddress(ctx context.Context, container dockerData) string {
logger := log.FromContext(ctx)
+ netNotFound := false
if container.ExtraConf.Docker.Network != "" {
settings := container.NetworkSettings
if settings.Networks != nil {
@@ -318,7 +319,8 @@ func (p Provider) getIPAddress(ctx context.Context, container dockerData) string
return network.Addr
}
- logger.Warnf("Could not find network named '%s' for container '%s'! Maybe you're missing the project's prefix in the label? Defaulting to first available network.", container.ExtraConf.Docker.Network, container.Name)
+ netNotFound = true
+ logger.Debugf("Could not find network named %q for container %q. Maybe you're missing the project's prefix in the label?", container.ExtraConf.Docker.Network, container.Name)
}
}
@@ -367,6 +369,9 @@ func (p Provider) getIPAddress(ctx context.Context, container dockerData) string
}
for _, network := range container.NetworkSettings.Networks {
+ if netNotFound {
+ logger.Warnf("Defaulting to first available network (%q) for container %q.", network, container.Name)
+ }
return network.Addr
}
--
GitLab