From cc254e85ed86e1f8c9052f9cbf0e3320324f0421 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Paul=20Li=C3=A9tar?= <lietarp@gmail.com>
Date: Thu, 27 Feb 2025 00:53:12 +0000
Subject: [PATCH] Unset NOTIFY_SOCKET when running the temporary server.
(#1325)
* Unset NOTIFY_SOCKET when running the temporary server.
Postgres has native support for this notification socket and will write a `READY=1` message once it is ready and accepting connections. Unfortunately, the temporary server used by the `docker-entrypoint.sh` also sends a message on the socket, making it appear as though the container is ready and serving connections when it is not.
---
13/alpine3.20/docker-entrypoint.sh | 3 +++
13/alpine3.21/docker-entrypoint.sh | 3 +++
13/bookworm/docker-entrypoint.sh | 3 +++
13/bullseye/docker-entrypoint.sh | 3 +++
14/alpine3.20/docker-entrypoint.sh | 3 +++
14/alpine3.21/docker-entrypoint.sh | 3 +++
14/bookworm/docker-entrypoint.sh | 3 +++
14/bullseye/docker-entrypoint.sh | 3 +++
15/alpine3.20/docker-entrypoint.sh | 3 +++
15/alpine3.21/docker-entrypoint.sh | 3 +++
15/bookworm/docker-entrypoint.sh | 3 +++
15/bullseye/docker-entrypoint.sh | 3 +++
16/alpine3.20/docker-entrypoint.sh | 3 +++
16/alpine3.21/docker-entrypoint.sh | 3 +++
16/bookworm/docker-entrypoint.sh | 3 +++
16/bullseye/docker-entrypoint.sh | 3 +++
17/alpine3.20/docker-entrypoint.sh | 3 +++
17/alpine3.21/docker-entrypoint.sh | 3 +++
17/bookworm/docker-entrypoint.sh | 3 +++
17/bullseye/docker-entrypoint.sh | 3 +++
docker-entrypoint.sh | 3 +++
21 files changed, 63 insertions(+)
diff --git a/13/alpine3.20/docker-entrypoint.sh b/13/alpine3.20/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/13/alpine3.20/docker-entrypoint.sh
+++ b/13/alpine3.20/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/13/alpine3.21/docker-entrypoint.sh b/13/alpine3.21/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/13/alpine3.21/docker-entrypoint.sh
+++ b/13/alpine3.21/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/13/bookworm/docker-entrypoint.sh b/13/bookworm/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/13/bookworm/docker-entrypoint.sh
+++ b/13/bookworm/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/13/bullseye/docker-entrypoint.sh b/13/bullseye/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/13/bullseye/docker-entrypoint.sh
+++ b/13/bullseye/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/14/alpine3.20/docker-entrypoint.sh b/14/alpine3.20/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/14/alpine3.20/docker-entrypoint.sh
+++ b/14/alpine3.20/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/14/alpine3.21/docker-entrypoint.sh b/14/alpine3.21/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/14/alpine3.21/docker-entrypoint.sh
+++ b/14/alpine3.21/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/14/bookworm/docker-entrypoint.sh b/14/bookworm/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/14/bookworm/docker-entrypoint.sh
+++ b/14/bookworm/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/14/bullseye/docker-entrypoint.sh b/14/bullseye/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/14/bullseye/docker-entrypoint.sh
+++ b/14/bullseye/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/15/alpine3.20/docker-entrypoint.sh b/15/alpine3.20/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/15/alpine3.20/docker-entrypoint.sh
+++ b/15/alpine3.20/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/15/alpine3.21/docker-entrypoint.sh b/15/alpine3.21/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/15/alpine3.21/docker-entrypoint.sh
+++ b/15/alpine3.21/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/15/bookworm/docker-entrypoint.sh b/15/bookworm/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/15/bookworm/docker-entrypoint.sh
+++ b/15/bookworm/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/15/bullseye/docker-entrypoint.sh b/15/bullseye/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/15/bullseye/docker-entrypoint.sh
+++ b/15/bullseye/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/16/alpine3.20/docker-entrypoint.sh b/16/alpine3.20/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/16/alpine3.20/docker-entrypoint.sh
+++ b/16/alpine3.20/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/16/alpine3.21/docker-entrypoint.sh b/16/alpine3.21/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/16/alpine3.21/docker-entrypoint.sh
+++ b/16/alpine3.21/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/16/bookworm/docker-entrypoint.sh b/16/bookworm/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/16/bookworm/docker-entrypoint.sh
+++ b/16/bookworm/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/16/bullseye/docker-entrypoint.sh b/16/bullseye/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/16/bullseye/docker-entrypoint.sh
+++ b/16/bullseye/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/17/alpine3.20/docker-entrypoint.sh b/17/alpine3.20/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/17/alpine3.20/docker-entrypoint.sh
+++ b/17/alpine3.20/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/17/alpine3.21/docker-entrypoint.sh b/17/alpine3.21/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/17/alpine3.21/docker-entrypoint.sh
+++ b/17/alpine3.21/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/17/bookworm/docker-entrypoint.sh b/17/bookworm/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/17/bookworm/docker-entrypoint.sh
+++ b/17/bookworm/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/17/bullseye/docker-entrypoint.sh b/17/bullseye/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/17/bullseye/docker-entrypoint.sh
+++ b/17/bullseye/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
diff --git a/docker-entrypoint.sh b/docker-entrypoint.sh
index d09b538..ae40666 100755
--- a/docker-entrypoint.sh
+++ b/docker-entrypoint.sh
@@ -269,6 +269,9 @@ docker_temp_server_start() {
# does not listen on external TCP/IP and waits until start finishes
set -- "$@" -c listen_addresses='' -p "${PGPORT:-5432}"
+ # unset NOTIFY_SOCKET so the temporary server doesn't prematurely notify
+ # any process supervisor.
+ NOTIFY_SOCKET= \
PGUSER="${PGUSER:-$POSTGRES_USER}" \
pg_ctl -D "$PGDATA" \
-o "$(printf '%q ' "$@")" \
--
GitLab