From 8ec5492d87c2891ddc7e8c6b691e7246b8c027a2 Mon Sep 17 00:00:00 2001
From: Pawel Rozlach <vespian@users.noreply.github.com>
Date: Wed, 3 Nov 2021 10:15:04 +0100
Subject: [PATCH] fix: use full domain name for notification-controller
Signed-off-by: Pawel Rozlach <vespian@users.noreply.github.com>
---
pkg/manifestgen/install/manifests.go | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/pkg/manifestgen/install/manifests.go b/pkg/manifestgen/install/manifests.go
index 908eeec1..5089074f 100644
--- a/pkg/manifestgen/install/manifests.go
+++ b/pkg/manifestgen/install/manifests.go
@@ -65,7 +65,15 @@ func fetch(ctx context.Context, url, version, dir string) error {
func generate(base string, options Options) error {
if containsItemString(options.Components, options.NotificationController) {
- options.EventsAddr = fmt.Sprintf("http://%s/", options.NotificationController)
+ // We need to use full domain name here, as some users may deploy flux
+ // in environments that use http proxy.
+ //
+ // In such environments they normally add `.cluster.local` and `.local`
+ // suffixes to `no_proxy` variable in order to prevent cluster-local
+ // traffic from going through http proxy. Without fully specified
+ // domain they need to mention `notifications-controller` explicity in
+ // `no_proxy` variable after debugging http proxy logs.
+ options.EventsAddr = fmt.Sprintf("http://%s.%s.svc.%s/", options.NotificationController, options.Namespace, options.ClusterDomain)
}
if err := execTemplate(options, namespaceTmpl, path.Join(base, "namespace.yaml")); err != nil {
--
GitLab