From 22af0ced348ccfafcc8b20a467629b4a0534b123 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20T=C3=B6lle?= <julian.toelle@hetzner-cloud.de> Date: Mon, 21 Nov 2022 11:33:22 +0100 Subject: [PATCH] fix: driver version not updated on tagged release (#328) This version of the driver was not updated on new releases. This causes the user-agent to include the old version. --- .github/workflows/publish_on_tag.yml | 3 ++- script/updateversion.bash | 6 ------ 2 files changed, 2 insertions(+), 7 deletions(-) delete mode 100755 script/updateversion.bash diff --git a/.github/workflows/publish_on_tag.yml b/.github/workflows/publish_on_tag.yml index ff1ab36..5d6d2db 100644 --- a/.github/workflows/publish_on_tag.yml +++ b/.github/workflows/publish_on_tag.yml @@ -18,10 +18,11 @@ jobs: OWNER: ${{ github.repository_owner }} run: | sed -i -e "s#: .*/hcloud-csi-driver:latest#: $OWNER/hcloud-csi-driver:$RELEASE_VERSION#" deploy/kubernetes/hcloud-csi.yml + sed -i -e "s/PluginVersion = \".*\"$/PluginVersion = \"$RELEASE_VERSION\"/g" driver/driver.go git config user.name github-actions git config user.email github-actions@github.com git add . - git commit -m "Update image tags in hcloud-csi.yml to $RELEASE_VERSION" + git commit -m "Update version tags to $RELEASE_VERSION" git tag -d v$RELEASE_VERSION git tag v$RELEASE_VERSION git push origin v$RELEASE_VERSION -f diff --git a/script/updateversion.bash b/script/updateversion.bash deleted file mode 100755 index 40f4779..0000000 --- a/script/updateversion.bash +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/bash -VERSION="$1" -sed -i "" -e "s/image: hetznercloud\/hcloud-csi-driver:.*$/image: hetznercloud\/hcloud-csi-driver:$VERSION/g" deploy/kubernetes/*.yml -sed -i "" -e "s/## master/## v$VERSION/g" CHANGES.md -sed -i "" -e "s/PluginVersion = \".*\"$/PluginVersion = \"$VERSION\"/g" driver/driver.go -goimports -w driver/driver.go -- GitLab