Skip to content
Snippets Groups Projects
Unverified Commit f11aa0df authored by Anurag's avatar Anurag Committed by GitHub
Browse files

feat(helm): remove "v" prefix from chart version (#565)


This makes sure that the chart version is fully semver compliant, as Helm expects.

Fixes #529

Signed-off-by: default avatarkranurag7 <81210977+kranurag7@users.noreply.github.com>
Co-authored-by: default avatarJulian Tölle <julian.toelle@hetzner-cloud.de>
Release-As: 1.19.0-rc.0
parent 956c2efe
Branches
Tags
No related merge requests found
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
before: before:
hooks: hooks:
- go mod tidy - go mod tidy
- ./scripts/release-generate-deployment-yamls.sh {{ if not .IsSnapshot }}v{{ end }}{{ .Version }} - ./scripts/release-generate-deployment-yamls.sh {{ .Version }}
builds: builds:
- id: hcloud-cloud-controller-manager - id: hcloud-cloud-controller-manager
...@@ -59,6 +59,6 @@ publishers: ...@@ -59,6 +59,6 @@ publishers:
ids: [""] ids: [""]
checksum: true checksum: true
cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ if not .IsSnapshot }}v{{ end }}{{ .Version }}.tgz cmd: ./scripts/publish-helm-chart.sh hcloud-cloud-controller-manager-{{ .Version }}.tgz
env: env:
- CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }} - CHART_REPO_REMOTE={{ .Env.CHART_REPO_REMOTE }}
apiVersion: v2 apiVersion: v2
name: hcloud-cloud-controller-manager name: hcloud-cloud-controller-manager
type: application type: application
version: v1.18.0 # x-release-please-version version: 1.18.0 # x-release-please-version
...@@ -50,7 +50,7 @@ env: ...@@ -50,7 +50,7 @@ env:
image: image:
repository: hetznercloud/hcloud-cloud-controller-manager repository: hetznercloud/hcloud-cloud-controller-manager
tag: '{{ $.Chart.Version }}' tag: 'v{{ $.Chart.Version }}'
monitoring: monitoring:
# When enabled, the hccm Pod will serve metrics on port :8233 # When enabled, the hccm Pod will serve metrics on port :8233
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment