From 1687d46e687e6e27c36448200b8a38cb25b8b0d1 Mon Sep 17 00:00:00 2001 From: Alfred Krohmer <alfred.krohmer@goto.com> Date: Tue, 25 Mar 2025 12:57:27 +0100 Subject: [PATCH] fix: remove default value for `awsRegion` value in cluster-autoscaler Helm chart to avoid accidental misconfigurations The region should be specified explicitly. Having a default might be dangerous as cluster-autoscaler might find matching autoscaling groups in other regions that belong to a different cluster and wipe all nodes in them as it doesn't recognize these as belonging to its own cluster. --- charts/cluster-autoscaler/Chart.yaml | 2 +- charts/cluster-autoscaler/README.md | 2 +- charts/cluster-autoscaler/values.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/cluster-autoscaler/Chart.yaml b/charts/cluster-autoscaler/Chart.yaml index 2f533563ef..0e1a5a99d8 100644 --- a/charts/cluster-autoscaler/Chart.yaml +++ b/charts/cluster-autoscaler/Chart.yaml @@ -11,4 +11,4 @@ name: cluster-autoscaler sources: - https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler type: application -version: 9.46.3 +version: 9.46.4 diff --git a/charts/cluster-autoscaler/README.md b/charts/cluster-autoscaler/README.md index 5ccbdd3ffd..420da9d18d 100644 --- a/charts/cluster-autoscaler/README.md +++ b/charts/cluster-autoscaler/README.md @@ -428,7 +428,7 @@ vpa: | autoscalingGroups | list | `[]` | For AWS, Azure AKS, Exoscale or Magnum. At least one element is required if not using `autoDiscovery`. For example: <pre> - name: asg1<br /> maxSize: 2<br /> minSize: 1 </pre> For Hetzner Cloud, the `instanceType` and `region` keys are also required. <pre> - name: mypool<br /> maxSize: 2<br /> minSize: 1<br /> instanceType: CPX21<br /> region: FSN1 </pre> | | autoscalingGroupsnamePrefix | list | `[]` | For GCE. At least one element is required if not using `autoDiscovery`. For example: <pre> - name: ig01<br /> maxSize: 10<br /> minSize: 0 </pre> | | awsAccessKeyID | string | `""` | AWS access key ID ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)) | -| awsRegion | string | `"us-east-1"` | AWS region (required if `cloudProvider=aws`) | +| awsRegion | string | `""` | AWS region (required if `cloudProvider=aws`) | | awsSecretAccessKey | string | `""` | AWS access secret key ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)) | | azureClientID | string | `""` | Service Principal ClientID with contributor permission to Cluster and Node ResourceGroup. Required if `cloudProvider=azure` | | azureClientSecret | string | `""` | Service Principal ClientSecret with contributor permission to Cluster and Node ResourceGroup. Required if `cloudProvider=azure` | diff --git a/charts/cluster-autoscaler/values.yaml b/charts/cluster-autoscaler/values.yaml index 663f4f65ee..d744739760 100644 --- a/charts/cluster-autoscaler/values.yaml +++ b/charts/cluster-autoscaler/values.yaml @@ -73,7 +73,7 @@ autoscalingGroupsnamePrefix: [] awsAccessKeyID: "" # awsRegion -- AWS region (required if `cloudProvider=aws`) -awsRegion: us-east-1 +awsRegion: "" # awsSecretAccessKey -- AWS access secret key ([if AWS user keys used](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#using-aws-credentials)) awsSecretAccessKey: "" -- GitLab