From a361d25ce64e827821d4ca3ac54cd63eb9af0090 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20K=C5=82obuszewski?= <danielmk@google.com> Date: Thu, 29 May 2025 16:29:58 +0200 Subject: [PATCH] Remove stale TODO We had async node drain for years now. --- cluster-autoscaler/metrics/metrics.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/cluster-autoscaler/metrics/metrics.go b/cluster-autoscaler/metrics/metrics.go index 3717e0247e..ebc5541c5e 100644 --- a/cluster-autoscaler/metrics/metrics.go +++ b/cluster-autoscaler/metrics/metrics.go @@ -504,9 +504,7 @@ func UpdateDurationFromStart(label FunctionLabel, start time.Time) { // UpdateDuration records the duration of the step identified by the label func UpdateDuration(label FunctionLabel, duration time.Duration) { - // TODO(maciekpytel): remove second condition if we manage to get - // asynchronous node drain - if duration > LogLongDurationThreshold && label != ScaleDown { + if duration > LogLongDurationThreshold { klog.V(4).Infof("Function %s took %v to complete", label, duration) } functionDuration.WithLabelValues(string(label)).Observe(duration.Seconds()) -- GitLab