From 64425be6b9cfe503230f6d1bd9a16922b937aa56 Mon Sep 17 00:00:00 2001 From: Peter Fiddes <peter.fiddes@gmail.com> Date: Wed, 29 Nov 2017 11:31:42 +0000 Subject: [PATCH] contrib: namespace warning to kube-prometheus NAMESPACE feature in scripts implies it works. warnning ensures that users are aware that its use requires further changes. Alleviates #765 --- hack/cluster-monitoring/deploy | 3 +++ hack/cluster-monitoring/teardown | 3 +++ 2 files changed, 6 insertions(+) diff --git a/hack/cluster-monitoring/deploy b/hack/cluster-monitoring/deploy index 818db48c..a4f7c184 100755 --- a/hack/cluster-monitoring/deploy +++ b/hack/cluster-monitoring/deploy @@ -4,6 +4,9 @@ if [ -z "${KUBECONFIG}" ]; then export KUBECONFIG=~/.kube/config fi +# CAUTION - setting NAMESPACE will deploy most components to the given namespace +# however some are hardcoded to 'monitoring'. Only use if you have reviewed all manifests. + if [ -z "${NAMESPACE}" ]; then NAMESPACE=monitoring fi diff --git a/hack/cluster-monitoring/teardown b/hack/cluster-monitoring/teardown index ac4d222d..b2c4c544 100755 --- a/hack/cluster-monitoring/teardown +++ b/hack/cluster-monitoring/teardown @@ -4,6 +4,9 @@ if [ -z "${KUBECONFIG}" ]; then export KUBECONFIG=~/.kube/config fi +# CAUTION - NAMESPACE must match its value when deploy script was run. +# Some resources are always deployed to the monitoring namespace. + if [ -z "${NAMESPACE}" ]; then NAMESPACE=monitoring fi -- GitLab