From 73e3dffa72d87d37d0b07b61d992fa061f5ac854 Mon Sep 17 00:00:00 2001 From: Svend Sorensen <ssorensen@whitepages.com> Date: Mon, 30 Oct 2017 13:16:22 -0700 Subject: [PATCH] Omit static compute resource requests and limits from deployment Do not specify static resource settings in the kubernetes-deployment to avoid unnecessary replacement of pods when the manifest is reapplied (`kubectl apply`). The addon-resizer will dynamically set the pod compute resource values. If the values are also set statically in the deployment configuration, reapplying the configuration will result in the pods getting replaced. Without the static resource, the deployment configuration can be reapplied, and the pods will not be replaced. This change was also made in the upstream kube-state-metrics example manifests. https://github.com/kubernetes/kube-state-metrics/pull/285 --- .../kube-state-metrics/kube-state-metrics-deployment.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/manifests/kube-state-metrics/kube-state-metrics-deployment.yaml b/manifests/kube-state-metrics/kube-state-metrics-deployment.yaml index bd313f21..ee8526d3 100644 --- a/manifests/kube-state-metrics/kube-state-metrics-deployment.yaml +++ b/manifests/kube-state-metrics/kube-state-metrics-deployment.yaml @@ -22,13 +22,6 @@ spec: port: 8080 initialDelaySeconds: 5 timeoutSeconds: 5 - resources: - requests: - memory: 100Mi - cpu: 100m - limits: - memory: 200Mi - cpu: 200m - name: addon-resizer image: gcr.io/google_containers/addon-resizer:1.0 resources: -- GitLab