Skip to content
Snippets Groups Projects
  • Marco Massarotto's avatar
    929231b4
    Feat/allow ghe changelog (#1981) · 929231b4
    Marco Massarotto authored
    This PR follows up and fixes #1968
    
    The previous PR didn't behave correctly as it was expecting Github Enterprise to ALWAYS been configured and that the github.com token was available in the `GITHUB_COM_TOKEN` env variable.
    But for non GHE project `GITHUB_COM_TOKEN` is not defined and github.com token is available at the `GITHUB_TOKEN` env variable instead.
    
    This updated PR fix this issue and avoid further problems by prioritising `github.com` over GHE.
    Now the code is NOOP if no `GITHUB_ENDPOINT` is configured.
    
    If it's configured, instead, now the codes assumes that, by DEFAULT, a dependency is hosted on `github.com` so it removes `GITHUB_ENDPOINT` and use `GITHUB_COM_TOKEN` as Github token immediately.
    They are restored only if needed, when a dependency is hosted on the provided GithubEnterprise.
    929231b4
    History
    Feat/allow ghe changelog (#1981)
    Marco Massarotto authored
    This PR follows up and fixes #1968
    
    The previous PR didn't behave correctly as it was expecting Github Enterprise to ALWAYS been configured and that the github.com token was available in the `GITHUB_COM_TOKEN` env variable.
    But for non GHE project `GITHUB_COM_TOKEN` is not defined and github.com token is available at the `GITHUB_TOKEN` env variable instead.
    
    This updated PR fix this issue and avoid further problems by prioritising `github.com` over GHE.
    Now the code is NOOP if no `GITHUB_ENDPOINT` is configured.
    
    If it's configured, instead, now the codes assumes that, by DEFAULT, a dependency is hosted on `github.com` so it removes `GITHUB_ENDPOINT` and use `GITHUB_COM_TOKEN` as Github token immediately.
    They are restored only if needed, when a dependency is hosted on the provided GithubEnterprise.