From 031d94d7ed4a4406488928c3b7eb6b0296da61d4 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Mon, 5 Nov 2018 11:34:28 +0100
Subject: [PATCH] Revert "fix(docker): null is not a valid version"
This reverts commit 8f0279ec3a77a13919cfc10d8f3cf3fe5b55a9bc.
---
lib/versioning/docker/index.js | 3 ---
test/versioning/docker.spec.js | 3 +--
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/versioning/docker/index.js b/lib/versioning/docker/index.js
index 92a0592e7f..1124b4f4d5 100644
--- a/lib/versioning/docker/index.js
+++ b/lib/versioning/docker/index.js
@@ -52,9 +52,6 @@ function isLessThanRange(version, range) {
return compare(version, range) < 0;
}
function isValid(version) {
- if (!version) {
- return null;
- }
const parsed = parse(version);
return parsed ? version : null;
}
diff --git a/test/versioning/docker.spec.js b/test/versioning/docker.spec.js
index cc5e6db048..72acd0755e 100644
--- a/test/versioning/docker.spec.js
+++ b/test/versioning/docker.spec.js
@@ -4,7 +4,6 @@ const semver = require('../../lib/versioning')('semver');
describe('docker.isValid(input)', () => {
describe('isValid(version)', () => {
it('should support all versions length', () => {
- expect(docker.isValid(null)).toBe(null);
expect(docker.isValid('1.2.3')).toBe('1.2.3');
expect(docker.isValid('18.04')).toBe('18.04');
expect(docker.isValid('10.1')).toBe('10.1');
@@ -12,7 +11,7 @@ describe('docker.isValid(input)', () => {
expect(docker.isValid('foo')).toBe(null);
});
});
- describe('getMajor(version)', () => {
+ describe('isValid(version)', () => {
it('should support all versions length', () => {
expect(docker.getMajor('1.2.3')).toBe(1);
expect(docker.getMajor('18.04')).toBe(18);
--
GitLab