From 03698c211abb7a68807dd3d6d7606f3bf41d03bc Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Fri, 25 Jan 2019 06:36:27 +0100
Subject: [PATCH] refactor: default rollbackPrs=false
---
lib/config/definitions.js | 6 ++----
test/workers/repository/process/lookup/index.spec.js | 4 ++++
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/config/definitions.js b/lib/config/definitions.js
index c1672a5c5b..90eefb9416 100644
--- a/lib/config/definitions.js
+++ b/lib/config/definitions.js
@@ -706,7 +706,7 @@ const options = [
description:
'Create PRs to roll back versions if the current version is not found in the registry',
type: 'boolean',
- default: true,
+ default: false,
},
{
name: 'recreateClosed',
@@ -999,6 +999,7 @@ const options = [
type: 'json',
default: {
fileMatch: ['(^|/)package.json$'],
+ rollbackPrs: true,
versionScheme: 'npm',
},
mergeable: true,
@@ -1019,7 +1020,6 @@ const options = [
stage: 'package',
type: 'json',
default: {
- rollbackPrs: false,
fileMatch: ['(^|/)WORKSPACE$'],
prBodyDefinitions: {
Change:
@@ -1048,7 +1048,6 @@ const options = [
stage: 'package',
type: 'json',
default: {
- rollbackPrs: false,
commitMessageTopic: 'module {{depNameShort}}',
},
mergeable: true,
@@ -1181,7 +1180,6 @@ const options = [
managerBranchPrefix: 'docker-',
commitMessageTopic: '{{{depName}}} Docker tag',
major: { enabled: false },
- rollbackPrs: false,
commitMessageExtra:
'to v{{#if isMajor}}{{{newMajor}}}{{else}}{{{newVersion}}}{{/if}}',
digest: {
diff --git a/test/workers/repository/process/lookup/index.spec.js b/test/workers/repository/process/lookup/index.spec.js
index 1683b30e53..49d325da45 100644
--- a/test/workers/repository/process/lookup/index.spec.js
+++ b/test/workers/repository/process/lookup/index.spec.js
@@ -30,6 +30,7 @@ describe('workers/repository/process/lookup', () => {
config.currentValue = '0.9.99';
config.depName = 'q';
config.purl = 'pkg:npm/q';
+ config.rollbackPrs = true;
nock('https://registry.npmjs.org')
.get('/q')
.reply(200, qJson);
@@ -39,6 +40,7 @@ describe('workers/repository/process/lookup', () => {
config.currentValue = '^0.9.99';
config.depName = 'q';
config.purl = 'pkg:npm/q';
+ config.rollbackPrs = true;
nock('https://registry.npmjs.org')
.get('/q')
.reply(200, qJson);
@@ -725,6 +727,7 @@ describe('workers/repository/process/lookup', () => {
config.depName = 'typescript';
config.purl = 'pkg:npm/typescript';
config.followTag = 'insiders';
+ config.rollbackPrs = true;
nock('https://registry.npmjs.org')
.get('/typescript')
.reply(200, typescriptJson);
@@ -797,6 +800,7 @@ describe('workers/repository/process/lookup', () => {
config.currentValue = '1.16.1';
config.depName = 'coffeelint';
config.purl = 'pkg:npm/coffeelint';
+ config.rollbackPrs = true;
nock('https://registry.npmjs.org')
.get('/coffeelint')
.reply(200, coffeelintJson);
--
GitLab