From 0638bfd716ef902ccb6d4aefabd30b8e3d3d556f Mon Sep 17 00:00:00 2001
From: Sergei Zharinov <zharinov@users.noreply.github.com>
Date: Sat, 27 Nov 2021 12:32:39 +0300
Subject: [PATCH] refactor(workers): Strict nulls for CommitMessage class
(#12863)
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
---
lib/workers/repository/model/commit-message.ts | 8 ++++----
tsconfig.strict.json | 1 +
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/workers/repository/model/commit-message.ts b/lib/workers/repository/model/commit-message.ts
index c62dd048b7..bab8afd4f6 100644
--- a/lib/workers/repository/model/commit-message.ts
+++ b/lib/workers/repository/model/commit-message.ts
@@ -1,9 +1,9 @@
export class CommitMessage {
public static readonly SEPARATOR: string = ':';
- private message: string;
+ private message = '';
- private prefix: string;
+ private prefix = '';
constructor(message = '') {
this.setMessage(message);
@@ -26,11 +26,11 @@ export class CommitMessage {
}
public setCustomPrefix(prefix?: string): void {
- this.prefix = (prefix || '').trim();
+ this.prefix = (prefix ?? '').trim();
}
public setSemanticPrefix(type?: string, scope?: string): void {
- this.prefix = (type || '').trim();
+ this.prefix = (type ?? '').trim();
if (scope?.trim()) {
this.prefix += `(${scope.trim()})`;
diff --git a/tsconfig.strict.json b/tsconfig.strict.json
index 2f67feec4c..3e8b6d89ff 100644
--- a/tsconfig.strict.json
+++ b/tsconfig.strict.json
@@ -122,6 +122,7 @@
"./lib/workers/pr/changelog/hbs-template.ts",
"./lib/workers/pr/changelog/types.ts",
"./lib/workers/repository/init/types.ts",
+ "./lib/workers/repository/model/commit-message.ts",
"./test/graphql-snapshot.ts",
"./test/json-schema.ts",
"./test/newline-snapshot-serializer.ts",
--
GitLab