From 08f7a5ca9148e9dca0b6893e562e5135d05d2538 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Sun, 25 Jun 2017 08:14:59 +0200
Subject: [PATCH] Complete code coverage (#347)
---
lib/workers/branch.js | 5 +----
lib/workers/package-file.js | 5 +----
test/api/gitlab.spec.js | 7 +------
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/lib/workers/branch.js b/lib/workers/branch.js
index 8e75b18301..691d0c1a27 100644
--- a/lib/workers/branch.js
+++ b/lib/workers/branch.js
@@ -210,11 +210,8 @@ async function updateBranch(upgrades) {
branch: branchName,
});
- const upgradeCount = upgrades.length === 1
- ? '1 upgrade'
- : `${upgrades.length} upgrades`;
logger.info(
- `Branch '${branchName}' has ${upgradeCount}: ${upgrades.map(
+ `Branch '${branchName}' has ${upgrades.length} upgrade(s): ${upgrades.map(
upgrade => upgrade.depName
)}`
);
diff --git a/lib/workers/package-file.js b/lib/workers/package-file.js
index ae1bd98b74..630e10c28f 100644
--- a/lib/workers/package-file.js
+++ b/lib/workers/package-file.js
@@ -147,11 +147,8 @@ async function findUpgrades(dependencies) {
dep.config
);
if (upgrades.length > 0) {
- const upgradeCount = upgrades.length === 1
- ? '1 upgrade'
- : `${upgrades.length} upgrades`;
logger.info(
- `Dependency ${dep.depName} has ${upgradeCount} available: ${upgrades.map(
+ `Dependency ${dep.depName} has ${upgrades.length} upgrade(s) available: ${upgrades.map(
upgrade => upgrade.newVersion
)}`
);
diff --git a/test/api/gitlab.spec.js b/test/api/gitlab.spec.js
index 7a2b253854..b4fc7a0a40 100644
--- a/test/api/gitlab.spec.js
+++ b/test/api/gitlab.spec.js
@@ -582,12 +582,7 @@ describe('api/gitlab', () => {
describe('commitFilesToBranch(branchName, files, message, parentBranch)', () => {
it('creates branch', async () => {
glGot.mockReturnValueOnce({ statusCode: 404 });
- await gitlab.commitFilesToBranch(
- 'some-branch',
- [],
- 'some-message',
- 'parent-branch'
- );
+ await gitlab.commitFilesToBranch('some-branch', [], 'some-message');
});
it('does not create branch and updates file', async () => {
glGot.mockReturnValueOnce({ statusCode: 200 });
--
GitLab