From 138d99a04f5b8f1cf0ef06ad3eb4ec1fc19852f9 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Wed, 1 Nov 2017 09:45:30 +0100
Subject: [PATCH] feat: default lockFileMaintenance to disabled (#1066)
Closes #590
BREAKING CHANGE: lock file maintenance is now disabled by default.
---
docs/configuration.md | 2 +-
lib/config/definitions.js | 2 +-
test/config/__snapshots__/index.spec.js.snap | 2 +-
test/workers/package-file/index.spec.js | 1 +
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/configuration.md b/docs/configuration.md
index d5f52daf4b..51a09dd298 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -691,7 +691,7 @@ Obviously, you can't set repository or package file location with this method.
<td>Configuration for lock file maintenance</td>
<td>json</td>
<td><pre>{
- "enabled": true,
+ "enabled": false,
"recreateClosed": true,
"branchName": "{{branchPrefix}}lock-file-maintenance",
"commitMessage": "Update lock file",
diff --git a/lib/config/definitions.js b/lib/config/definitions.js
index 50b49c2922..9424d974b8 100644
--- a/lib/config/definitions.js
+++ b/lib/config/definitions.js
@@ -534,7 +534,7 @@ const options = [
stage: 'packageFile',
type: 'json',
default: {
- enabled: true,
+ enabled: false,
recreateClosed: true,
branchName: template('branchName', 'lock-file-maintenance'),
commitMessage: template('commitMessage', 'lock-file-maintenance'),
diff --git a/test/config/__snapshots__/index.spec.js.snap b/test/config/__snapshots__/index.spec.js.snap
index 3fade9624a..0ed3ce4eb7 100644
--- a/test/config/__snapshots__/index.spec.js.snap
+++ b/test/config/__snapshots__/index.spec.js.snap
@@ -4,7 +4,7 @@ exports[`config/index mergeChildConfig(parentConfig, childConfig) merges 1`] = `
Object {
"branchName": "{{branchPrefix}}lock-file-maintenance",
"commitMessage": "Update lock file",
- "enabled": true,
+ "enabled": false,
"groupName": null,
"prBody": "This {{#if isGitHub}}Pull{{else}}Merge{{/if}} Request updates \`package.json\` lock files to use the latest dependency versions.
diff --git a/test/workers/package-file/index.spec.js b/test/workers/package-file/index.spec.js
index 248b1b7b93..9dae27fae2 100644
--- a/test/workers/package-file/index.spec.js
+++ b/test/workers/package-file/index.spec.js
@@ -52,6 +52,7 @@ describe('packageFileWorker', () => {
expect(res).toHaveLength(0);
});
it('maintains lock files', async () => {
+ config.lockFileMaintenance.enabled = true;
config.yarnLock = '# some yarn lock';
const res = await packageFileWorker.renovatePackageFile(config);
expect(res).toHaveLength(1);
--
GitLab