From 14bfee02443a4321451e3ef5c0da41805a879535 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@keylocation.sg> Date: Sun, 15 Jan 2017 15:19:19 +0100 Subject: [PATCH] Refactor tests --- test/helpers/npm.js | 10 +++++----- test/helpers/package-json.js | 4 ++-- test/index.js | 4 ---- test/mocha.opts | 2 ++ 4 files changed, 9 insertions(+), 11 deletions(-) delete mode 100644 test/index.js create mode 100644 test/mocha.opts diff --git a/test/helpers/npm.js b/test/helpers/npm.js index 025f065c01..5368f53c1e 100644 --- a/test/helpers/npm.js +++ b/test/helpers/npm.js @@ -10,8 +10,8 @@ chai.should(); const input01Content = fs.readFileSync('./test/_fixtures/package.json/inputs/01.json', 'utf8'); const input02Content = fs.readFileSync('./test/_fixtures/package.json/inputs/02.json', 'utf8'); -describe('npm helper', () => { - describe('extractDependencies', () => { +describe('helpers/npm', () => { + describe('.extractDependencies(packageJson, sections)', () => { it('returns an array of correct length', () => { const extractedDependencies = npm.extractDependencies(JSON.parse(input01Content), defaultTypes); extractedDependencies.should.be.instanceof(Array); @@ -28,7 +28,7 @@ describe('npm helper', () => { extractedDependencies.should.have.length(6); }); }); - describe('getUpgrades', () => { + describe('.getUpgrades(depName, currentVersion, versions)', () => { const testVersions = ['0.1.0', '1.0.0', '1.0.1', '1.1.0', '2.0.0-alpha1', '2.0.0', '2.0.1', '3.0.0', '3.1.0']; it('return empty if invalid current version', () => { npm.getUpgrades('foo', 'invalid', ['1.0.0', '1.0.1']).should.have.length(0); @@ -71,7 +71,7 @@ describe('npm helper', () => { npm.getUpgrades('foo', '^3.0.0', testVersions).should.eql(upgradeVersions); }); }); - describe('isRange', () => { + describe('.isRange(input)', () => { it('rejects simple semver', () => { npm.isRange('1.2.3').should.eql(false); }); @@ -82,7 +82,7 @@ describe('npm helper', () => { npm.isRange('^1.2.3').should.eql(true); }); }); - describe('isValidVersion', () => { + describe('.isValidVersion(input)', () => { it('should support simple semver', () => { npm.isValidVersion('1.2.3').should.eql(true); }); diff --git a/test/helpers/package-json.js b/test/helpers/package-json.js index 6228e03452..d171685fb1 100644 --- a/test/helpers/package-json.js +++ b/test/helpers/package-json.js @@ -4,8 +4,8 @@ const packageJson = require('../../lib/helpers/package-json'); const inputContent = fs.readFileSync('./test/_fixtures/package.json/inputs/01.json', 'utf8'); -describe('package.json helper', () => { - describe('setNewValue', () => { +describe('helpers/package-json', () => { + describe('.setNewValue(currentFileContent, depType, depName, newVersion)', () => { it('replaces a dependency value', () => { const outputContent = fs.readFileSync('./test/_fixtures/package.json/outputs/011.json', 'utf8'); const testContent = diff --git a/test/index.js b/test/index.js deleted file mode 100644 index 2514d3bf09..0000000000 --- a/test/index.js +++ /dev/null @@ -1,4 +0,0 @@ -require('./worker'); -require('./helpers/github'); -require('./helpers/npm'); -require('./helpers/package-json'); diff --git a/test/mocha.opts b/test/mocha.opts new file mode 100644 index 0000000000..f41d094e52 --- /dev/null +++ b/test/mocha.opts @@ -0,0 +1,2 @@ +--recursive +--reporter spec -- GitLab