From 157b1a3f79806d290e7f5cb4893e8abb5fcdbaf5 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Mon, 29 Jan 2024 11:16:22 +0100
Subject: [PATCH] fix(pnpm): better log warning for updateLockFile() (#26909)
---
.../manager/npm/update/locked-dependency/index.spec.ts | 6 ++++++
.../manager/npm/update/locked-dependency/index.ts | 10 +++++++++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/modules/manager/npm/update/locked-dependency/index.spec.ts b/lib/modules/manager/npm/update/locked-dependency/index.spec.ts
index 054d8a449c..11f54635c4 100644
--- a/lib/modules/manager/npm/update/locked-dependency/index.spec.ts
+++ b/lib/modules/manager/npm/update/locked-dependency/index.spec.ts
@@ -245,5 +245,11 @@ describe('modules/manager/npm/update/locked-dependency/index', () => {
const res = await updateLockedDependency(config);
expect(res.status).toBe('update-failed');
});
+
+ it('fails if pnpm', async () => {
+ config.lockFile = 'pnpm-lock.yaml';
+ const res = await updateLockedDependency(config);
+ expect(res.status).toBe('update-failed');
+ });
});
});
diff --git a/lib/modules/manager/npm/update/locked-dependency/index.ts b/lib/modules/manager/npm/update/locked-dependency/index.ts
index 7d6e10b961..c9a4782b40 100644
--- a/lib/modules/manager/npm/update/locked-dependency/index.ts
+++ b/lib/modules/manager/npm/update/locked-dependency/index.ts
@@ -19,6 +19,14 @@ export async function updateLockedDependency(
if (lockFile.endsWith('yarn.lock')) {
return yarnLock.updateLockedDependency(config);
}
- logger.debug(`Unsupported lock file: ${lockFile}`);
+ if (lockFile.endsWith('pnpm-lock.yaml')) {
+ logger.debug(
+ 'updateLockedDependency(): pnpm is not supported yet. See https://github.com/renovatebot/renovate/issues/21438',
+ );
+ } else {
+ logger.debug(
+ `updateLockedDependency(): unsupported lock file: ${lockFile}`,
+ );
+ }
return { status: 'update-failed' };
}
--
GitLab