diff --git a/lib/platform/azure/index.ts b/lib/platform/azure/index.ts index 9cbc7d690b6cb132871f86f0c3edab9095bac7cf..b9facb5f288488f2d7f7e3e14a5ba7320a921852 100644 --- a/lib/platform/azure/index.ts +++ b/lib/platform/azure/index.ts @@ -43,7 +43,7 @@ interface Config { owner: string; repoId: string; project: string; - azureWorkItemId: any; + azureWorkItemId: string; prList: Pr[]; fileList: null; repository: string; @@ -297,9 +297,7 @@ export async function findPr({ prTitle, state = 'all', }: FindPRConfig): Promise<Pr | null> { - logger.debug(`findPr(${branchName}, ${prTitle}, ${state})`); - // TODO: fix typing - let prsFiltered: any[] = []; + let prsFiltered: Pr[] = []; try { const prs = await getPrList(); @@ -404,7 +402,7 @@ export async function getBranchStatusCheck( export async function getBranchStatus( branchName: string, - requiredStatusChecks: any + requiredStatusChecks: string[] ): Promise<BranchStatus> { logger.debug(`getBranchStatus(${branchName})`); if (!requiredStatusChecks) { @@ -439,7 +437,7 @@ export async function createPr({ id: config.azureWorkItemId, }, ]; - let pr: any = await azureApiGit.createPullRequest( + let pr: GitPullRequest = await azureApiGit.createPullRequest( { sourceRefName, targetRefName, @@ -453,7 +451,7 @@ export async function createPr({ pr = await azureApiGit.updatePullRequest( { autoCompleteSetBy: { - id: pr.createdBy!.id, + id: pr.createdBy.id, }, completionOptions: { mergeStrategy: config.mergeMethod, @@ -461,7 +459,7 @@ export async function createPr({ }, }, config.repoId, - pr.pullRequestId! + pr.pullRequestId ); } await Promise.all( @@ -471,11 +469,10 @@ export async function createPr({ name: label, }, config.repoId, - pr.pullRequestId! + pr.pullRequestId ) ) ); - pr.branchName = branchName; return azureHelper.getRenovatePRFormat(pr); } @@ -486,7 +483,7 @@ export async function updatePr( ): Promise<void> { logger.debug(`updatePr(${prNo}, ${title}, body)`); const azureApiGit = await azureApi.gitApi(); - const objToUpdate: any = { + const objToUpdate: GitPullRequest = { title, }; if (body) { @@ -682,7 +679,7 @@ export async function addReviewers( ) ); - const ids: any[] = []; + const ids: { id: string; name: string }[] = []; members.forEach(listMembers => { listMembers.forEach(m => { reviewers.forEach(r => { diff --git a/test/platform/azure/__snapshots__/index.spec.ts.snap b/test/platform/azure/__snapshots__/index.spec.ts.snap index c7d29e87faef6cd586400271b04a2d3ae134b536..d3ce8c6ad57481dd2543175f295599c8aceb5401 100644 --- a/test/platform/azure/__snapshots__/index.spec.ts.snap +++ b/test/platform/azure/__snapshots__/index.spec.ts.snap @@ -21,7 +21,6 @@ Object { "autoCompleteSetBy": Object { "id": 123, }, - "branchName": "some-branch", "completionOptions": Object { "deleteSourceBranch": true, "squashMerge": true,