From 16c080fadc01094ec29f3fa642d85536fd8b5b5c Mon Sep 17 00:00:00 2001
From: Sergei Zharinov <zharinov@users.noreply.github.com>
Date: Mon, 19 Apr 2021 17:51:02 +0400
Subject: [PATCH] refactor(util): Fix unbound methods usage (#9626)
---
lib/util/exec/docker/index.ts | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/util/exec/docker/index.ts b/lib/util/exec/docker/index.ts
index bf0a39c2fa..2ae548575a 100644
--- a/lib/util/exec/docker/index.ts
+++ b/lib/util/exec/docker/index.ts
@@ -72,11 +72,9 @@ async function getDockerTag(
constraint: string,
scheme: string
): Promise<string> {
- // TODO: fixme
- // eslint-disable-next-line @typescript-eslint/unbound-method
- const { isValid, isVersion, matches, sortVersions } = versioning.get(scheme);
+ const ver = versioning.get(scheme);
- if (!isValid(constraint)) {
+ if (!ver.isValid(constraint)) {
logger.warn({ constraint }, `Invalid ${scheme} version constraint`);
return 'latest';
}
@@ -93,9 +91,9 @@ async function getDockerTag(
if (imageReleases?.releases) {
let versions = imageReleases.releases.map((release) => release.version);
versions = versions.filter(
- (version) => isVersion(version) && matches(version, constraint)
+ (version) => ver.isVersion(version) && ver.matches(version, constraint)
);
- versions = versions.sort(sortVersions);
+ versions = versions.sort(ver.sortVersions.bind(ver));
if (versions.length) {
const version = versions.pop();
logger.debug(
--
GitLab