From 17387fcf48e926b767989fe7c1c20ad5fbebab90 Mon Sep 17 00:00:00 2001
From: Michael Kriese <michael.kriese@visualon.de>
Date: Mon, 25 Jul 2022 14:54:46 +0200
Subject: [PATCH] fix(manager/nuget): skip invalid xml files (#16758)
---
lib/modules/manager/nuget/package-tree.spec.ts | 6 ++----
lib/modules/manager/nuget/package-tree.ts | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/modules/manager/nuget/package-tree.spec.ts b/lib/modules/manager/nuget/package-tree.spec.ts
index e16f5a223c..d200483f6e 100644
--- a/lib/modules/manager/nuget/package-tree.spec.ts
+++ b/lib/modules/manager/nuget/package-tree.spec.ts
@@ -155,12 +155,10 @@ describe('modules/manager/nuget/package-tree', () => {
);
});
- it('throws error on invalid xml file', async () => {
+ it('skips on invalid xml file', async () => {
git.getFileList.mockResolvedValue(['foo/bar.csproj']);
Fixtures.mock({ '/tmp/repo/foo/bar.csproj': '<invalid' });
- await expect(getDependentPackageFiles('foo/bar.csproj')).rejects.toThrow(
- 'Invalid xml file: foo/bar.csproj'
- );
+ expect(await getDependentPackageFiles('foo/bar.csproj')).toEqual([]);
});
});
});
diff --git a/lib/modules/manager/nuget/package-tree.ts b/lib/modules/manager/nuget/package-tree.ts
index db23febed6..e1bafc9c30 100644
--- a/lib/modules/manager/nuget/package-tree.ts
+++ b/lib/modules/manager/nuget/package-tree.ts
@@ -40,7 +40,7 @@ export async function getDependentPackageFiles(
for (const f of packageFiles) {
const doc = await readFileAsXmlDocument(f);
if (!doc) {
- throw new Error(`Invalid xml file: ${f}`);
+ continue;
}
const projectReferenceAttributes = doc
--
GitLab