From 1827b6f5192b10df4dd6505d48c2c6a439d4a71c Mon Sep 17 00:00:00 2001
From: Sergei Zharinov <zharinov@users.noreply.github.com>
Date: Thu, 8 Sep 2022 09:25:25 +0300
Subject: [PATCH] refactor(github): Don't inherit `github-tags` from
`github-releases` (#17696)
---
lib/modules/datasource/github-releases/index.ts | 8 ++++----
lib/modules/datasource/github-tags/index.ts | 12 +++++++++---
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/lib/modules/datasource/github-releases/index.ts b/lib/modules/datasource/github-releases/index.ts
index afd04862a1..ded3879a9a 100644
--- a/lib/modules/datasource/github-releases/index.ts
+++ b/lib/modules/datasource/github-releases/index.ts
@@ -21,15 +21,15 @@ function inferHashAlg(digest: string): string {
}
export class GithubReleasesDatasource extends Datasource {
- static id = 'github-releases';
+ static readonly id = 'github-releases';
override readonly defaultRegistryUrls = ['https://github.com'];
override http: GithubHttp;
- constructor(id = GithubReleasesDatasource.id) {
- super(id);
- this.http = new GithubHttp(id);
+ constructor() {
+ super(GithubReleasesDatasource.id);
+ this.http = new GithubHttp(GithubReleasesDatasource.id);
}
async findDigestFile(
diff --git a/lib/modules/datasource/github-tags/index.ts b/lib/modules/datasource/github-tags/index.ts
index 095a263f57..41f43aa4df 100644
--- a/lib/modules/datasource/github-tags/index.ts
+++ b/lib/modules/datasource/github-tags/index.ts
@@ -1,14 +1,20 @@
import { logger } from '../../../logger';
-import { GithubReleasesDatasource } from '../github-releases';
+import { GithubHttp } from '../../../util/http/github';
+import { Datasource } from '../datasource';
import { getApiBaseUrl, getSourceUrl } from '../github-releases/common';
import type { DigestConfig, GetReleasesConfig, ReleaseResult } from '../types';
import type { GitHubTag, TagResponse } from './types';
-export class GithubTagsDatasource extends GithubReleasesDatasource {
- static override readonly id = 'github-tags';
+export class GithubTagsDatasource extends Datasource {
+ static readonly id = 'github-tags';
+
+ override readonly defaultRegistryUrls = ['https://github.com'];
+
+ override http: GithubHttp;
constructor() {
super(GithubTagsDatasource.id);
+ this.http = new GithubHttp(GithubTagsDatasource.id);
}
async getTagCommit(
--
GitLab