From 20e68f4325a6898892380699e6e64d2a15f77bce Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Sat, 23 Mar 2019 22:14:41 +0100
Subject: [PATCH] fix(npm): better skipInstalls check
---
lib/manager/npm/post-update/lerna.js | 6 +++---
lib/manager/npm/post-update/npm.js | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/manager/npm/post-update/lerna.js b/lib/manager/npm/post-update/lerna.js
index 09b6538359..1b2fe87a81 100644
--- a/lib/manager/npm/post-update/lerna.js
+++ b/lib/manager/npm/post-update/lerna.js
@@ -34,10 +34,10 @@ async function generateLockFiles(
logger.debug('Using lerna version ' + lernaVersion);
let params;
if (lernaClient === 'npm') {
- if (skipInstalls) {
- params = '--package-lock-only --no-audit';
- } else {
+ if (skipInstalls === false) {
params = '--ignore-scripts --no-audit';
+ } else {
+ params = '--package-lock-only --no-audit';
}
} else {
params =
diff --git a/lib/manager/npm/post-update/npm.js b/lib/manager/npm/post-update/npm.js
index 9c6dc96d06..7a4d89c1f8 100644
--- a/lib/manager/npm/post-update/npm.js
+++ b/lib/manager/npm/post-update/npm.js
@@ -64,10 +64,10 @@ async function generateLockFile(
cmd = 'npm';
}
args = `install`;
- if (skipInstalls) {
- args += ' --package-lock-only --no-audit';
- } else {
+ if (skipInstalls === false) {
args += ' --ignore-scripts --no-audit';
+ } else {
+ args += ' --package-lock-only --no-audit';
}
logger.debug(`Using npm: ${cmd} ${args}`);
// TODO: Switch to native util.promisify once using only node 8
--
GitLab