From 2667ea16d104b0d2f4cd04579a4f3b74a266b72e Mon Sep 17 00:00:00 2001 From: Chuck Grindel <chuck.grindel@gmail.com> Date: Fri, 7 Apr 2023 22:24:39 -0600 Subject: [PATCH] fix: update cache record TTL to not account for Daylight Saving time (#21389) --- .../github/graphql/cache-strategies/package-cache-strategy.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/util/github/graphql/cache-strategies/package-cache-strategy.ts b/lib/util/github/graphql/cache-strategies/package-cache-strategy.ts index 1de0b93b52..6459f170c4 100644 --- a/lib/util/github/graphql/cache-strategies/package-cache-strategy.ts +++ b/lib/util/github/graphql/cache-strategies/package-cache-strategy.ts @@ -17,7 +17,9 @@ export class GithubGraphqlPackageCacheStrategy< ): Promise<void> { if (this.hasUpdatedItems) { const expiry = this.createdAt.plus({ - days: AbstractGithubGraphqlCacheStrategy.cacheTTLDays, + // Not using 'days' as it does not handle adjustments for Daylight Saving time. + // The offset in the resulting DateTime object does not match that of the expiry or this.now. + hours: AbstractGithubGraphqlCacheStrategy.cacheTTLDays * 24, }); const ttlMinutes = expiry.diff(this.now, ['minutes']).as('minutes'); if (ttlMinutes && ttlMinutes > 0) { -- GitLab