From 27e30f1379a0fdac77540bd8a6cace9af6b40162 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Mon, 5 Nov 2018 11:34:20 +0100 Subject: [PATCH] Revert "fix(docker): compare only if non-null" This reverts commit ad83405379c9225d5789a11859a5f206ca967d6d. --- lib/versioning/docker/index.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/versioning/docker/index.js b/lib/versioning/docker/index.js index ba6830e1ef..92a0592e7f 100644 --- a/lib/versioning/docker/index.js +++ b/lib/versioning/docker/index.js @@ -10,10 +10,6 @@ function parse(version) { function compare(version1, vervion2) { const parsed1 = parse(version1); const parsed2 = parse(vervion2); - // istanbul ignore if - if (!(parsed1 && parsed2)) { - return 1; - } const length = Math.max(parsed1.release.length, parsed2.release.length); for (let i = 0; i < length; i += 1) { const part1 = parsed1.release[i]; -- GitLab