From 2830a33aab9bbea8666f3e5df1bc588b89016bc6 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Fri, 26 Jan 2018 11:49:44 +0100 Subject: [PATCH] fix: check for valid lockedVersion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When pinning, check that the “version” in a lock file is a valid semver, and ignore it if not. --- lib/workers/package/versions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/workers/package/versions.js b/lib/workers/package/versions.js index 5aa0b34334..71f51809fa 100644 --- a/lib/workers/package/versions.js +++ b/lib/workers/package/versions.js @@ -30,7 +30,7 @@ function determineUpgrades(npmDep, config) { // Check for a current range and pin it if (isRange(currentVersion)) { let newVersion; - if (lockedVersion) { + if (lockedVersion && semver.valid(lockedVersion)) { newVersion = lockedVersion; } else { // Pin ranges to their maximum satisfying version -- GitLab