From 2bbbc956e9bcd828d417d8172c9876cf6471d170 Mon Sep 17 00:00:00 2001
From: Michael Kriese <michael.kriese@visualon.de>
Date: Mon, 25 Jul 2022 14:31:53 +0200
Subject: [PATCH] fix(manager/nuget): Skip dep if version is undefined (#16757)
---
lib/modules/manager/nuget/__fixtures__/sample.csproj | 1 +
lib/modules/manager/nuget/extract.ts | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/modules/manager/nuget/__fixtures__/sample.csproj b/lib/modules/manager/nuget/__fixtures__/sample.csproj
index 8bf93b13f5..37a002bbce 100644
--- a/lib/modules/manager/nuget/__fixtures__/sample.csproj
+++ b/lib/modules/manager/nuget/__fixtures__/sample.csproj
@@ -34,6 +34,7 @@
<PackageReference Include="NotUpdatable3" Version="(1.2.3, 3.2.1)" />
<PackageReference Include="NotUpdatable3" Version="[1.2.3, 3.2.1]" />
<PackageReference Include="NotUpdatable3" Version="[1.2.3, 3.2.1)" />
+ <PackageReference Include="NotUpdatable3" />
</ItemGroup>
<ItemGroup>
<DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="1.0.0" />
diff --git a/lib/modules/manager/nuget/extract.ts b/lib/modules/manager/nuget/extract.ts
index ec032b7d5a..bd17f2b7bc 100644
--- a/lib/modules/manager/nuget/extract.ts
+++ b/lib/modules/manager/nuget/extract.ts
@@ -1,3 +1,4 @@
+import is from '@sindresorhus/is';
import { XmlDocument, XmlElement, XmlNode } from 'xmldoc';
import { logger } from '../../../logger';
import { getSiblingFileName, localPathExists } from '../../../util/fs';
@@ -48,10 +49,9 @@ function extractDepsFromXml(xmlNode: XmlDocument): PackageDependency[] {
child.valueWithPath('Version') ??
attr?.VersionOverride ??
child.valueWithPath('VersionOverride');
- const currentValue = checkVersion
-
- ?.exec(version)
- ?.groups?.currentValue?.trim();
+ const currentValue = is.nonEmptyStringAndNotWhitespace(version)
+ ? checkVersion.exec(version)?.groups?.currentValue?.trim()
+ : undefined;
if (depName && currentValue) {
results.push({
datasource: NugetDatasource.id,
--
GitLab