From 2cd741d1df356aa41c5fd7dd3d8c83685ce7c046 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Wed, 1 Nov 2017 08:57:49 +0100
Subject: [PATCH] feat: deprecate ignoreFuture configuration option (#1063)
Drop support for (unused) ignoreFuture option.
Closes #588
BREAKING CHANGE: Support is removed for ignoreFuture configuration option
---
lib/workers/package/versions.js | 14 --------------
.../__snapshots__/versions.spec.js.snap | 19 ++-----------------
test/workers/package/versions.spec.js | 6 ------
3 files changed, 2 insertions(+), 37 deletions(-)
diff --git a/lib/workers/package/versions.js b/lib/workers/package/versions.js
index 8abf96d020..faf6df1989 100644
--- a/lib/workers/package/versions.js
+++ b/lib/workers/package/versions.js
@@ -9,7 +9,6 @@ module.exports = {
determineUpgrades,
isRange,
isValidVersion,
- isFuture,
isPastLatest,
};
@@ -64,13 +63,6 @@ function determineUpgrades(npmDep, config) {
stable.is(changeLogFromVersion) &&
!stable.is(version)
)
- // Ignore future versions, unless the current version is marked as future
- .reject(
- version =>
- config.ignoreFuture &&
- !isFuture(versions[changeLogFromVersion]) &&
- isFuture(versions[version])
- )
// Ignore versions newer than "latest", unless current version is newer than the "latest"
.reject(
version =>
@@ -231,12 +223,6 @@ function isValidVersion(input) {
return (semver.valid(input) || semver.validRange(input)) !== null;
}
-function isFuture(version) {
- return (
- version && version.publishConfig && version.publishConfig.tag === 'future'
- );
-}
-
function isPastLatest(npmDep, version) {
if (npmDep['dist-tags'] && npmDep['dist-tags'].latest) {
return semver.gt(version, npmDep['dist-tags'].latest);
diff --git a/test/workers/package/__snapshots__/versions.spec.js.snap b/test/workers/package/__snapshots__/versions.spec.js.snap
index 90c15995c8..4d56bf0571 100644
--- a/test/workers/package/__snapshots__/versions.spec.js.snap
+++ b/test/workers/package/__snapshots__/versions.spec.js.snap
@@ -334,9 +334,9 @@ exports[`workers/package/versions .determineUpgrades(npmDep, config) supports >
Array [
Object {
"changeLogFromVersion": "1.4.1",
- "changeLogToVersion": "2.0.1",
+ "changeLogToVersion": "2.0.3",
"isMajor": true,
- "newVersion": "2.0.1",
+ "newVersion": "2.0.3",
"newVersionMajor": 2,
"newVersionMinor": 0,
"type": "major",
@@ -357,21 +357,6 @@ Array [
]
`;
-exports[`workers/package/versions .determineUpgrades(npmDep, config) supports future versions if configured 1`] = `
-Array [
- Object {
- "changeLogFromVersion": "1.4.1",
- "changeLogToVersion": "2.0.3",
- "isMajor": true,
- "newVersion": "2.0.3",
- "newVersionMajor": 2,
- "newVersionMinor": 0,
- "type": "major",
- "unpublishable": false,
- },
-]
-`;
-
exports[`workers/package/versions .determineUpgrades(npmDep, config) supports minor and major upgrades for ranged versions 1`] = `
Array [
Object {
diff --git a/test/workers/package/versions.spec.js b/test/workers/package/versions.spec.js
index a04e5d8f39..67faa39b49 100644
--- a/test/workers/package/versions.spec.js
+++ b/test/workers/package/versions.spec.js
@@ -177,12 +177,6 @@ describe('workers/package/versions', () => {
config.currentVersion = '1.4.1';
expect(versions.determineUpgrades(qJson, config)).toMatchSnapshot();
});
- it('supports future versions if configured', () => {
- config.ignoreFuture = false;
- config.respectLatest = false;
- config.currentVersion = '1.4.1';
- expect(versions.determineUpgrades(qJson, config)).toMatchSnapshot();
- });
it('supports future versions if already future', () => {
config.currentVersion = '^2.0.0';
expect(versions.determineUpgrades(qJson, config)).toMatchSnapshot();
--
GitLab