From 31b8d44fa199adfa251aa079c01b6d4336ae39fe Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Wed, 3 Feb 2021 22:04:55 +0100
Subject: [PATCH] logs: improve npm constraint logging
---
lib/manager/npm/post-update/npm.ts | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/lib/manager/npm/post-update/npm.ts b/lib/manager/npm/post-update/npm.ts
index d63e6c5e09..ff442d980d 100644
--- a/lib/manager/npm/post-update/npm.ts
+++ b/lib/manager/npm/post-update/npm.ts
@@ -28,8 +28,19 @@ export async function generateLockFile(
try {
let installNpm = 'npm i -g npm';
const npmCompatibility = config.constraints?.npm as string;
- if (validRange(npmCompatibility)) {
- installNpm = `npm i -g ${quote(`npm@${npmCompatibility}`)}`;
+ // istanbul ignore else
+ if (npmCompatibility) {
+ // istanbul ignore else
+ if (validRange(npmCompatibility)) {
+ installNpm = `npm i -g ${quote(`npm@${npmCompatibility}`)}`;
+ } else {
+ logger.debug(
+ { npmCompatibility },
+ 'npm compatibility range is not valid - skipping'
+ );
+ }
+ } else {
+ logger.debug('No npm compatibility range found - installing npm latest');
}
const preCommands = [installNpm, 'hash -d npm'];
const commands = [];
--
GitLab