From 31fb0b09aa1ac41e7ff5acd9d0e4f6e9f14bd288 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Sat, 23 Mar 2019 08:15:09 +0100 Subject: [PATCH] =?UTF-8?q?fix(schema):=20don=E2=80=99t=20skip=20falsey=20?= =?UTF-8?q?default?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- bin/create-json-schema.js | 2 +- renovate-schema.json | 88 ++++++++++++++++++++++++++------------- 2 files changed, 60 insertions(+), 30 deletions(-) diff --git a/bin/create-json-schema.js b/bin/create-json-schema.js index 0cee41d71f..eabb8cce7e 100644 --- a/bin/create-json-schema.js +++ b/bin/create-json-schema.js @@ -37,7 +37,7 @@ function createSingleConfig(option) { if (option.description) { temp.description = option.description; } - if (option.default) { + if (option.default !== undefined) { temp.default = option.default; } if (option.allowedValues) { diff --git a/renovate-schema.json b/renovate-schema.json index 162f51d494..a10850179f 100644 --- a/renovate-schema.json +++ b/renovate-schema.json @@ -35,15 +35,18 @@ }, "forceCli": { "type": "boolean", - "description": "Whether CLI configuration options should be moved to the `force` config section" + "description": "Whether CLI configuration options should be moved to the `force` config section", + "default": false }, "dryRun": { "type": "boolean", - "description": "If enabled, perform a dry run by logging messages instead of creating/updating/deleting branches and PRs" + "description": "If enabled, perform a dry run by logging messages instead of creating/updating/deleting branches and PRs", + "default": false }, "printConfig": { "type": "boolean", - "description": "If enabled, log the full resolved config for each repo, including resolved presets" + "description": "If enabled, log the full resolved config for each repo, including resolved presets", + "default": false }, "binarySource": { "type": "string", @@ -76,15 +79,18 @@ }, "includeForks": { "type": "boolean", - "description": "Whether to process forked repositories or not. By default, all forked repositories are skipped over." + "description": "Whether to process forked repositories or not. By default, all forked repositories are skipped over.", + "default": false }, "forkMode": { "type": "boolean", - "description": "Set to true to fork the source repository and create branches there instead" + "description": "Set to true to fork the source repository and create branches there instead", + "default": false }, "requireConfig": { "type": "boolean", - "description": "Set to true if repositories must have a config to activate." + "description": "Set to true if repositories must have a config to activate.", + "default": false }, "privateKey": { "type": "string", @@ -93,7 +99,8 @@ "encrypted": { "type": "object", "$ref": "#", - "description": "A configuration object containing configuration encrypted with project key." + "description": "A configuration object containing configuration encrypted with project key.", + "default": null }, "timezone": { "type": "string", @@ -114,6 +121,7 @@ "gitFs": { "type": "string", "description": "Use git for FS operations instead of API. GitHub only.", + "default": null, "enum": ["https", "http", "ssh"] }, "trustLevel": { @@ -128,7 +136,8 @@ }, "endpoint": { "type": "string", - "description": "Custom endpoint to use" + "description": "Custom endpoint to use", + "default": null }, "token": { "type": "string", @@ -160,19 +169,23 @@ }, "skipInstalls": { "type": "boolean", - "description": "Skip installing modules/dependencies if lock file updating is possible alone" + "description": "Skip installing modules/dependencies if lock file updating is possible alone", + "default": null }, "ignoreNpmrcFile": { "type": "boolean", - "description": "Whether to ignore any .npmrc file found in repository" + "description": "Whether to ignore any .npmrc file found in repository", + "default": false }, "autodiscover": { "type": "boolean", - "description": "Autodiscover all repositories" + "description": "Autodiscover all repositories", + "default": false }, "autodiscoverFilter": { "type": "string", - "description": "Filter the list of autodiscovered repositories" + "description": "Filter the list of autodiscovered repositories", + "default": null }, "repositories": { "type": "array", @@ -212,7 +225,8 @@ }, "registryUrls": { "type": "array", - "description": "List of URLs to try for dependency lookup. Package manager-specific" + "description": "List of URLs to try for dependency lookup. Package manager-specific", + "default": null }, "versionScheme": { "type": "string", @@ -341,7 +355,8 @@ }, "pinDigests": { "type": "boolean", - "description": "Whether to add digests to Dockerfile source images" + "description": "Whether to add digests to Dockerfile source images", + "default": false }, "separateMajorMinor": { "type": "boolean", @@ -349,11 +364,13 @@ }, "separateMultipleMajor": { "type": "boolean", - "description": "If set to true, PRs will be raised separately for each available major upgrade version" + "description": "If set to true, PRs will be raised separately for each available major upgrade version", + "default": false }, "separateMinorPatch": { "type": "boolean", - "description": "If set to true, it will separate minor and patch updates into separate branches" + "description": "If set to true, it will separate minor and patch updates into separate branches", + "default": false }, "ignoreUnstable": { "type": "boolean", @@ -441,7 +458,8 @@ }, "semanticCommits": { "type": "boolean", - "description": "Enable semantic commit prefixes for commits and PR titles" + "description": "Enable semantic commit prefixes for commits and PR titles", + "default": null }, "semanticCommitType": { "type": "string", @@ -455,15 +473,18 @@ }, "rollbackPrs": { "type": "boolean", - "description": "Create PRs to roll back versions if the current version is not found in the registry" + "description": "Create PRs to roll back versions if the current version is not found in the registry", + "default": false }, "recreateClosed": { "type": "boolean", - "description": "Recreate PRs even if same ones were closed previously" + "description": "Recreate PRs even if same ones were closed previously", + "default": false }, "rebaseStalePrs": { "type": "boolean", - "description": "Rebase stale PRs (GitHub only)" + "description": "Rebase stale PRs (GitHub only)", + "default": null }, "rebaseLabel": { "type": "string", @@ -472,11 +493,13 @@ }, "statusCheckVerify": { "type": "boolean", - "description": "Set a verify status check for all PRs" + "description": "Set a verify status check for all PRs", + "default": false }, "unpublishSafe": { "type": "boolean", - "description": "Set a status check for unpublish-safe upgrades" + "description": "Set a status check for unpublish-safe upgrades", + "default": false }, "prCreation": { "type": "string", @@ -490,15 +513,18 @@ }, "prHourlyLimit": { "type": "integer", - "description": "Rate limit PRs to maximum x created per hour. 0 (default) means no limit." + "description": "Rate limit PRs to maximum x created per hour. 0 (default) means no limit.", + "default": 0 }, "prConcurrentLimit": { "type": "integer", - "description": "Limit to a maximum of x concurrent branches/PRs. 0 (default) means no limit." + "description": "Limit to a maximum of x concurrent branches/PRs. 0 (default) means no limit.", + "default": 0 }, "automerge": { "type": "boolean", - "description": "Whether to automerge branches/PRs automatically, without human intervention" + "description": "Whether to automerge branches/PRs automatically, without human intervention", + "default": false }, "automergeType": { "type": "string", @@ -534,7 +560,8 @@ }, "managerBranchPrefix": { "type": "string", - "description": "Branch manager prefix" + "description": "Branch manager prefix", + "default": "" }, "branchTopic": { "type": "string", @@ -575,7 +602,8 @@ }, "prTitle": { "type": "string", - "description": "Pull Request title template (deprecated). Now uses commitMessage." + "description": "Pull Request title template (deprecated). Now uses commitMessage.", + "default": null }, "prFooter": { "type": "string", @@ -605,11 +633,13 @@ }, "groupName": { "type": "string", - "description": "Human understandable name for the dependency group" + "description": "Human understandable name for the dependency group", + "default": null }, "groupSlug": { "type": "string", - "description": "Slug to use for group (e.g. in branch name). Will be calculated from groupName if null" + "description": "Slug to use for group (e.g. in branch name). Will be calculated from groupName if null", + "default": null }, "group": { "type": "object", -- GitLab