From 3265cbbb51b3f25b928e7373209c35e02af69912 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Fri, 18 Aug 2017 10:29:27 +0200
Subject: [PATCH] fix: onboarding packages should have : prefix (#693)
---
lib/workers/repository/onboarding.js | 4 ++--
.../repository/__snapshots__/onboarding.spec.js.snap | 6 +++---
test/workers/repository/onboarding.spec.js | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/workers/repository/onboarding.js b/lib/workers/repository/onboarding.js
index 881c1daf21..5beb03a4c1 100644
--- a/lib/workers/repository/onboarding.js
+++ b/lib/workers/repository/onboarding.js
@@ -26,10 +26,10 @@ async function createBranch(config) {
const repoIsPrivate = await module.exports.isRepoPrivate(config);
if (repoIsPrivate) {
config.logger.debug('Repo is private - setting to app type');
- onboardingConfig.extends = ['app'];
+ onboardingConfig.extends = [':app'];
} else {
config.logger.debug('Repo is not private - setting to library');
- onboardingConfig.extends = ['library'];
+ onboardingConfig.extends = [':library'];
}
const onboardingConfigString = `${stringify(onboardingConfig)}\n`;
const existingContent = await config.api.getFileContent(
diff --git a/test/workers/repository/__snapshots__/onboarding.spec.js.snap b/test/workers/repository/__snapshots__/onboarding.spec.js.snap
index 236a5c705e..752fa921a1 100644
--- a/test/workers/repository/__snapshots__/onboarding.spec.js.snap
+++ b/test/workers/repository/__snapshots__/onboarding.spec.js.snap
@@ -310,7 +310,7 @@ Array [
"renovate/configure",
Array [
Object {
- "contents": "{\\"extends\\": [\\"library\\"]}
+ "contents": "{\\"extends\\": [\\":library\\"]}
",
"name": "renovate.json",
},
@@ -324,7 +324,7 @@ Array [
"renovate/configure",
Array [
Object {
- "contents": "{\\"extends\\": [\\"library\\"]}
+ "contents": "{\\"extends\\": [\\":library\\"]}
",
"name": "renovate.json",
},
@@ -338,7 +338,7 @@ Array [
"renovate/configure",
Array [
Object {
- "contents": "{\\"extends\\": [\\"app\\"]}
+ "contents": "{\\"extends\\": [\\":app\\"]}
",
"name": "renovate.json",
},
diff --git a/test/workers/repository/onboarding.spec.js b/test/workers/repository/onboarding.spec.js
index 7ba914441c..cbff316296 100644
--- a/test/workers/repository/onboarding.spec.js
+++ b/test/workers/repository/onboarding.spec.js
@@ -296,7 +296,7 @@ describe('lib/workers/repository/onboarding', () => {
expect(config.api.commitFilesToBranch.mock.calls[0]).toMatchSnapshot();
});
it('skips commit files if existing content matches', async () => {
- const existingContent = '{"extends": ["library"]}\n';
+ const existingContent = '{"extends": [":library"]}\n';
config.api.getFileContent.mockReturnValueOnce(existingContent);
const res = await onboarding.getOnboardingStatus(config);
expect(res).toEqual(false);
--
GitLab