From 32e2140886a68eb63f9f01972820ea78a579b4c6 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Sun, 9 Dec 2018 13:12:10 +0100
Subject: [PATCH] fix(deprecations): do not raise warnings for onboarding repos
---
lib/workers/repository/process/deprecated.js | 8 +++++++-
.../process/__snapshots__/deprecated.spec.js.snap | 10 +++++++++-
test/workers/repository/process/deprecated.spec.js | 6 ++++++
3 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/lib/workers/repository/process/deprecated.js b/lib/workers/repository/process/deprecated.js
index 3a664a782a..0a9ba5c964 100644
--- a/lib/workers/repository/process/deprecated.js
+++ b/lib/workers/repository/process/deprecated.js
@@ -3,7 +3,13 @@ module.exports = {
};
async function raiseDeprecationWarnings(config, packageFiles) {
- if (config.suppressNotifications && config.suppressNotifications.includes('deprecationWarningIssues')) {
+ if (!config.repoIsOnboarded) {
+ return;
+ }
+ if (
+ config.suppressNotifications &&
+ config.suppressNotifications.includes('deprecationWarningIssues')
+ ) {
return;
}
const deprecatedPackages = {};
diff --git a/test/workers/repository/process/__snapshots__/deprecated.spec.js.snap b/test/workers/repository/process/__snapshots__/deprecated.spec.js.snap
index 158bc132b4..2a74300850 100644
--- a/test/workers/repository/process/__snapshots__/deprecated.spec.js.snap
+++ b/test/workers/repository/process/__snapshots__/deprecated.spec.js.snap
@@ -8,7 +8,15 @@ Array [
Please take the actions necessary to rename or substitute this deprecated package and commit to your base branch. If you wish to ignore this deprecation warning and continue using \`foo\` as-is, please add it to your [ignoreDeps](https://renovatebot.com/docs/configuration-options/#ignoredeps) array in Renovate config before closing this issue, otherwise another issue will be recreated the next time Renovate runs.
-Affected package file(s): \`package.json\`, \`frontend/package.json\`",
+Affected package file(s): \`package.json\`, \`frontend/package.json\`
+
+ Would you like to disable Renovate's deprecation warning issues? Add the following to your config:
+
+\`\`\`
+\\"suppressNotifications\\": [\\"deprecationWarningIssues\\"]
+\`\`\`
+
+",
],
]
`;
diff --git a/test/workers/repository/process/deprecated.spec.js b/test/workers/repository/process/deprecated.spec.js
index efb416f4e2..2ae2d15ca9 100644
--- a/test/workers/repository/process/deprecated.spec.js
+++ b/test/workers/repository/process/deprecated.spec.js
@@ -4,14 +4,20 @@ const {
describe('workers/repository/process/deprecated', () => {
describe('raiseDeprecationWarnings()', () => {
+ it('returns if onboarding', async () => {
+ const config = {};
+ await raiseDeprecationWarnings(config, {});
+ });
it('returns if disabled', async () => {
const config = {
+ repoIsOnboarded: true,
suppressNotifications: ['deprecationWarningIssues'],
};
await raiseDeprecationWarnings(config, {});
});
it('raises deprecation warnings', async () => {
const config = {
+ repoIsOnboarded: true,
suppressNotifications: [],
};
const packageFiles = {
--
GitLab