From 383302d433a25e27cc30d3f87a8fe83f828b819d Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Wed, 27 Dec 2017 06:40:24 +0100
Subject: [PATCH] refactor: info not warn if npm 401 response
---
lib/manager/npm/registry.js | 4 ++++
test/manager/npm/registry.spec.js | 7 +++++++
2 files changed, 11 insertions(+)
diff --git a/lib/manager/npm/registry.js b/lib/manager/npm/registry.js
index 5bcc66c77f..04ec83559d 100644
--- a/lib/manager/npm/registry.js
+++ b/lib/manager/npm/registry.js
@@ -84,6 +84,10 @@ async function getDependency(name) {
logger.trace({ dep }, 'dep');
return dep;
} catch (err) {
+ if (err.statusCode === 401) {
+ logger.info({ err, name }, `Dependency lookup unauthorized`);
+ return null;
+ }
if (err.statusCode === 404) {
logger.info({ err, name }, `Dependency not found`);
return null;
diff --git a/test/manager/npm/registry.spec.js b/test/manager/npm/registry.spec.js
index 63ca5b9430..0d1df746ad 100644
--- a/test/manager/npm/registry.spec.js
+++ b/test/manager/npm/registry.spec.js
@@ -45,6 +45,13 @@ describe('api/npm', () => {
const res = await npm.getDependency('foobarhome');
expect(res).toMatchSnapshot();
});
+ it('should return null if lookup fails 401', async () => {
+ nock('https://registry.npmjs.org')
+ .get('/foobar')
+ .reply(401);
+ const res = await npm.getDependency('foobar');
+ expect(res).toBeNull();
+ });
it('should return null if lookup fails', async () => {
nock('https://registry.npmjs.org')
.get('/foobar')
--
GitLab