From 395cab2398615d0107aaed404e9d2188fa38a860 Mon Sep 17 00:00:00 2001 From: Oleg Krivtsov <olegkrivtsov@gmail.com> Date: Thu, 16 Dec 2021 12:28:41 +0700 Subject: [PATCH] test(manager/gradle-wrapper): migrate to fs.readLocalFile (#13123) --- .../__snapshots__/artifacts.spec.ts.snap | 2 +- .../gradle-wrapper/artifacts-real.spec.ts | 22 +++++++++---------- lib/manager/gradle-wrapper/artifacts.spec.ts | 4 ++-- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/lib/manager/gradle-wrapper/__snapshots__/artifacts.spec.ts.snap b/lib/manager/gradle-wrapper/__snapshots__/artifacts.spec.ts.snap index e842281010..0e5de361fc 100644 --- a/lib/manager/gradle-wrapper/__snapshots__/artifacts.spec.ts.snap +++ b/lib/manager/gradle-wrapper/__snapshots__/artifacts.spec.ts.snap @@ -27,7 +27,7 @@ Array [ exports[`manager/gradle-wrapper/artifacts replaces existing value 1`] = ` Array [ Object { - "cmd": "<gradlew> wrapper --gradle-distribution-url https://services.gradle.org/distributions/gradle-6.3-bin.zip", + "cmd": "<gradlew> wrapper --gradle-version 6.3", "options": Object { "cwd": "/root/project/lib/manager/gradle-wrapper/__fixtures__/testFiles", "encoding": "utf-8", diff --git a/lib/manager/gradle-wrapper/artifacts-real.spec.ts b/lib/manager/gradle-wrapper/artifacts-real.spec.ts index e5ff7af128..96f4047e78 100644 --- a/lib/manager/gradle-wrapper/artifacts-real.spec.ts +++ b/lib/manager/gradle-wrapper/artifacts-real.spec.ts @@ -1,10 +1,11 @@ -import { readFile, readFileSync } from 'fs-extra'; +import { readFileSync } from 'fs-extra'; import Git from 'simple-git'; import { resolve } from 'upath'; import * as httpMock from '../../../test/http-mock'; import { git, partial } from '../../../test/util'; import { GlobalConfig } from '../../config/global'; import type { RepoGlobalConfig } from '../../config/types'; +import { readLocalFile } from '../../util/fs'; import type { StatusResult } from '../../util/git/types'; import { ifSystemSupportsGradle } from '../gradle/deep/__testutil__/gradle'; import type { UpdateArtifactsConfig } from '../types'; @@ -22,8 +23,8 @@ const config: UpdateArtifactsConfig = { newValue: '5.6.4', }; -function readString(...paths: string[]): Promise<string> { - return readFile(resolve(fixtures, ...paths), 'utf8'); +function readString(path: string): Promise<string> { + return readLocalFile(path, 'utf8'); } function readBinSync(...paths: string[]): Buffer { @@ -64,7 +65,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { packageFileName: 'gradle/wrapper/gradle-wrapper.properties', updatedDeps: [], newPackageFileContent: await readString( - `./expectedFiles/gradle/wrapper/gradle-wrapper.properties` + `../expectedFiles/gradle/wrapper/gradle-wrapper.properties` ), config: { ...config, newValue: '6.3' }, }); @@ -122,7 +123,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { packageFileName: 'gradle/wrapper/gradle-wrapper.properties', updatedDeps: [], newPackageFileContent: await readString( - `./testFiles/gradle/wrapper/gradle-wrapper.properties` + `../testFiles/gradle/wrapper/gradle-wrapper.properties` ), config, }); @@ -146,7 +147,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { packageFileName: 'gradle/wrapper/gradle-wrapper.properties', updatedDeps: [], newPackageFileContent: await readString( - `./testFiles/gradle/wrapper/gradle-wrapper.properties` + `../testFiles/gradle/wrapper/gradle-wrapper.properties` ), config, }); @@ -173,7 +174,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { packageFileName: 'gradle/wrapper/gradle-wrapper.properties', updatedDeps: [], newPackageFileContent: await readString( - `./testFiles/gradle/wrapper/gradle-wrapper.properties` + `../testFiles/gradle/wrapper/gradle-wrapper.properties` ), config, }); @@ -217,7 +218,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { }) ); - const newContent = await readString(`./gradle-wrapper-sum.properties`); + const newContent = await readString(`../gradle-wrapper-sum.properties`); const result = await gradleWrapper.updateArtifacts({ packageFileName: 'gradle/wrapper/gradle-wrapper.properties', @@ -237,10 +238,7 @@ describe('manager/gradle-wrapper/artifacts-real', () => { expect(result[0].artifactError).toBeUndefined(); expect( - await readString( - adminConfig.localDir, - `./gradle/wrapper/gradle-wrapper.properties` - ) + await readString(`gradle/wrapper/gradle-wrapper.properties`) ).toEqual(newContent); expect(httpMock.getTrace()).toEqual([ diff --git a/lib/manager/gradle-wrapper/artifacts.spec.ts b/lib/manager/gradle-wrapper/artifacts.spec.ts index 4d042f021f..28253c8785 100644 --- a/lib/manager/gradle-wrapper/artifacts.spec.ts +++ b/lib/manager/gradle-wrapper/artifacts.spec.ts @@ -1,4 +1,4 @@ -import { readFile, stat } from 'fs-extra'; +import { stat } from 'fs-extra'; import { resolve } from 'upath'; import { envMock, exec, mockExecAll } from '../../../test/exec-util'; import * as httpMock from '../../../test/http-mock'; @@ -37,7 +37,7 @@ addReplacingSerializer('gradlew.bat', '<gradlew>'); addReplacingSerializer('./gradlew', '<gradlew>'); function readString(...paths: string[]): Promise<string> { - return readFile(resolve(fixtures, ...paths), 'utf8'); + return fs.readLocalFile(resolve(fixtures, ...paths), 'utf8'); } describe('manager/gradle-wrapper/artifacts', () => { -- GitLab