From 39ef96e7d21448f6310cff7651969a1144695b3e Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Wed, 27 Feb 2019 09:48:45 +0100
Subject: [PATCH] refactor(gomod): log line to change if not containing depName
---
lib/manager/gomod/update.js | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/manager/gomod/update.js b/lib/manager/gomod/update.js
index 2c5fae4c95..02b24388c2 100644
--- a/lib/manager/gomod/update.js
+++ b/lib/manager/gomod/update.js
@@ -5,8 +5,9 @@ module.exports = {
};
function updateDependency(currentFileContent, upgrade) {
+ const { depName } = upgrade;
try {
- const depNameNoVersion = upgrade.depName
+ const depNameNoVersion = depName
.split('/')
.slice(0, 3)
.join('/');
@@ -17,6 +18,10 @@ function updateDependency(currentFileContent, upgrade) {
!lineToChange.includes(depNameNoVersion) &&
!lineToChange.includes('rethinkdb/rethinkdb-go.v5')
) {
+ logger.debug(
+ { lineToChange, depName },
+ "go.mod current line doesn't contain dependency"
+ );
return null;
}
let requireLine;
@@ -45,8 +50,8 @@ function updateDependency(currentFileContent, upgrade) {
newLine = lineToChange.replace(requireLine, `$1$2${upgrade.newValue}`);
}
if (upgrade.updateType === 'major') {
- if (upgrade.depName.startsWith('gopkg.in/')) {
- const oldV = upgrade.depName.split('.').pop();
+ if (depName.startsWith('gopkg.in/')) {
+ const oldV = depName.split('.').pop();
newLine = newLine.replace(`.${oldV}`, `.v${upgrade.newMajor}`);
// Package renames - I couldn't think of a better place to do this
newLine = newLine.replace(
--
GitLab