From 3dbabadecff1e0e11014ca1b7d0792ae72ca6e3b Mon Sep 17 00:00:00 2001
From: Michael Kriese <michael.kriese@visualon.de>
Date: Mon, 11 May 2020 12:12:55 +0200
Subject: [PATCH] refactor(internal): remove global updateRubyGemsVersions
(#6199)
---
lib/datasource/rubygems/get-rubygems-org.ts | 10 ++++++----
lib/globals.d.ts | 2 --
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/datasource/rubygems/get-rubygems-org.ts b/lib/datasource/rubygems/get-rubygems-org.ts
index 489a47f89b..1ac4f4088d 100644
--- a/lib/datasource/rubygems/get-rubygems-org.ts
+++ b/lib/datasource/rubygems/get-rubygems-org.ts
@@ -86,13 +86,15 @@ function isDataStale(): boolean {
return minutesElapsed >= 5;
}
+let _updateRubyGemsVersions: Promise<void> | undefined;
+
async function syncVersions(): Promise<void> {
if (isDataStale()) {
- global.updateRubyGemsVersions =
+ _updateRubyGemsVersions =
// eslint-disable-next-line @typescript-eslint/no-misused-promises
- global.updateRubyGemsVersions || updateRubyGemsVersions();
- await global.updateRubyGemsVersions;
- delete global.updateRubyGemsVersions;
+ _updateRubyGemsVersions || updateRubyGemsVersions();
+ await _updateRubyGemsVersions;
+ _updateRubyGemsVersions = null;
}
}
diff --git a/lib/globals.d.ts b/lib/globals.d.ts
index 4bc09bb772..ee1198a876 100644
--- a/lib/globals.d.ts
+++ b/lib/globals.d.ts
@@ -34,8 +34,6 @@ declare namespace NodeJS {
renovateCache: Renovate.Cache;
trustLevel?: string;
-
- updateRubyGemsVersions?: Promise<void>;
}
}
--
GitLab