diff --git a/lib/manager/helm-requirements/extract.ts b/lib/manager/helm-requirements/extract.ts index f69bd5b18408f52362a94aae39fbf75a3c364306..6a9339764cdcf951b8b076b4ecb61d676a53864e 100644 --- a/lib/manager/helm-requirements/extract.ts +++ b/lib/manager/helm-requirements/extract.ts @@ -46,20 +46,24 @@ export async function extractPackageFile( const res: PackageDependency = { depName: dep.name, currentValue: dep.version, - registryUrls: [dep.repository], }; - if (dep.repository.startsWith('@')) { - res.skipReason = 'placeholder-url'; - } else { - try { - const url = new URL(dep.repository); - if (url.protocol === 'file:') { - res.skipReason = 'local-dependency'; + if (dep.repository) { + res.registryUrls = [dep.repository]; + if (dep.repository.startsWith('@')) { + res.skipReason = 'placeholder-url'; + } else { + try { + const url = new URL(dep.repository); + if (url.protocol === 'file:') { + res.skipReason = 'local-dependency'; + } + } catch (err) { + logger.debug({ err }, 'Error parsing url'); + res.skipReason = 'invalid-url'; } - } catch (err) { - logger.debug({ err }, 'Error parsing url'); - res.skipReason = 'invalid-url'; } + } else { + res.skipReason = 'no-repository'; } return res; }); diff --git a/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap b/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap index 07439aa4ae33ae4dddca8f7298820dbd0424fe55..d96cd95435b6a29ccaacbbeab09dfb91743e1300 100644 --- a/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap +++ b/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap @@ -42,6 +42,11 @@ Object { ], "skipReason": "invalid-url", }, + Object { + "currentValue": "0.8.1", + "depName": "broken", + "skipReason": "no-repository", + }, ], } `; diff --git a/test/manager/helm-requirements/extract.spec.ts b/test/manager/helm-requirements/extract.spec.ts index c88321aea16cb188a6ae05d0d4c42eb8db147294..69fcf2dee32638ee823d2db8023b618153125351 100644 --- a/test/manager/helm-requirements/extract.spec.ts +++ b/test/manager/helm-requirements/extract.spec.ts @@ -24,6 +24,8 @@ describe('lib/manager/helm/extract', () => { - name: postgresql version: 0.8.1 repository: nope + - name: broken + version: 0.8.1 `; const fileName = 'requirements.yaml'; const result = await extractPackageFile(content, fileName);