From 4a0605a7654c42b05022b0bb321d907cd4666b09 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Tue, 1 Sep 2020 15:59:54 +0200
Subject: [PATCH] fix(changelog): harden check for fromVersion and toVersion
---
lib/workers/pr/changelog/index.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/workers/pr/changelog/index.ts b/lib/workers/pr/changelog/index.ts
index 0009c54f39..237cecf770 100644
--- a/lib/workers/pr/changelog/index.ts
+++ b/lib/workers/pr/changelog/index.ts
@@ -13,11 +13,11 @@ export async function getChangeLogJSON(
): Promise<ChangeLogResult | null> {
const { sourceUrl, versioning, fromVersion, toVersion } = args;
try {
- if (!sourceUrl) {
+ if (!(sourceUrl && fromVersion && toVersion)) {
return null;
}
const version = allVersioning.get(versioning);
- if (!fromVersion || version.equals(fromVersion, toVersion)) {
+ if (version.equals(fromVersion, toVersion)) {
return null;
}
--
GitLab