From 4b59bedaae5de201e90bc8dc6a4a5b6f05ff5ada Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Thu, 28 May 2020 14:09:28 +0200
Subject: [PATCH] fix: check if defined before includes
---
lib/datasource/metadata.ts | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/datasource/metadata.ts b/lib/datasource/metadata.ts
index 67e0b4312c..bb8a2ccc4b 100644
--- a/lib/datasource/metadata.ts
+++ b/lib/datasource/metadata.ts
@@ -114,14 +114,13 @@ export function addMetaData(
};
if (
- dep.changelogUrl &&
- dep.changelogUrl.includes('github.com') && // lgtm [js/incomplete-url-substring-sanitization]
+ dep.changelogUrl?.includes('github.com') && // lgtm [js/incomplete-url-substring-sanitization]
!dep.sourceUrl
) {
dep.sourceUrl = dep.changelogUrl;
}
// prettier-ignore
- if (dep.homepage && dep.homepage.includes('github.com')) { // lgtm [js/incomplete-url-substring-sanitization]
+ if (dep.homepage?.includes('github.com')) { // lgtm [js/incomplete-url-substring-sanitization]
if (!dep.sourceUrl) {
dep.sourceUrl = dep.homepage;
}
@@ -134,7 +133,7 @@ export function addMetaData(
});
extraBaseUrls.push('gitlab.com');
if (dep.sourceUrl) {
- if (URL.parse(dep.sourceUrl).hostname.includes('gitlab')) {
+ if (URL.parse(dep.sourceUrl).hostname?.includes('gitlab')) {
// try massaging it
dep.sourceUrl =
parse(massageGitlabUrl(dep.sourceUrl), {
--
GitLab