From 662a249ba06a3c5d78239648b9c5712a2f084a27 Mon Sep 17 00:00:00 2001
From: jgarec <jgarec@users.noreply.github.com>
Date: Tue, 15 Sep 2020 06:34:00 +0200
Subject: [PATCH] fix(migration): do not migrate semanticCommits if not
necessary (#7280)
---
lib/config/migration.spec.ts | 4 ++--
lib/config/migration.ts | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/config/migration.spec.ts b/lib/config/migration.spec.ts
index 46d4229a9f..08a2370b88 100644
--- a/lib/config/migration.spec.ts
+++ b/lib/config/migration.spec.ts
@@ -424,12 +424,12 @@ describe('config/migration', () => {
config = { semanticCommits: 'enabled' };
res = configMigration.migrateConfig(config);
- expect(res.isMigrated).toBe(true);
+ expect(res.isMigrated).toBe(false);
expect(res.migratedConfig).toMatchObject({ semanticCommits: 'enabled' });
config = { semanticCommits: 'disabled' };
res = configMigration.migrateConfig(config);
- expect(res.isMigrated).toBe(true);
+ expect(res.isMigrated).toBe(false);
expect(res.migratedConfig).toMatchObject({ semanticCommits: 'disabled' });
});
});
diff --git a/lib/config/migration.ts b/lib/config/migration.ts
index 7f0e77a93c..70e3118117 100644
--- a/lib/config/migration.ts
+++ b/lib/config/migration.ts
@@ -102,13 +102,15 @@ export function migrateConfig(
}
delete migratedConfig.gomodTidy;
} else if (key === 'semanticCommits') {
- isMigrated = true;
if (val === true) {
migratedConfig.semanticCommits = 'enabled';
+ isMigrated = true;
} else if (val === false) {
migratedConfig.semanticCommits = 'disabled';
+ isMigrated = true;
} else if (val !== 'enabled' && val !== 'disabled') {
migratedConfig.semanticCommits = 'auto';
+ isMigrated = true;
}
} else if (parentKey === 'hostRules' && key === 'platform') {
isMigrated = true;
--
GitLab