From 68f34a99ff59cd9e0153bf3b6ba3b30e2d8f551d Mon Sep 17 00:00:00 2001 From: Michael Kriese <michael.kriese@visualon.de> Date: Wed, 2 Aug 2023 14:17:11 +0200 Subject: [PATCH] chore: fix types (#23665) --- lib/modules/manager/helmv3/update.ts | 4 ++-- lib/modules/manager/maven/update.ts | 4 ++-- lib/modules/manager/npm/update/package-version/index.ts | 4 ++-- lib/modules/manager/nuget/update.ts | 4 ++-- lib/modules/manager/sbt/update.ts | 4 ++-- lib/modules/manager/types.ts | 4 ++-- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/modules/manager/helmv3/update.ts b/lib/modules/manager/helmv3/update.ts index d44d1dc121..cd742214e6 100644 --- a/lib/modules/manager/helmv3/update.ts +++ b/lib/modules/manager/helmv3/update.ts @@ -6,7 +6,7 @@ import type { BumpPackageVersionResult } from '../types'; export function bumpPackageVersion( content: string, currentValue: string, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): BumpPackageVersionResult { logger.debug( { bumpVersion, currentValue }, @@ -15,7 +15,7 @@ export function bumpPackageVersion( let newChartVersion: string | null; let bumpedContent = content; try { - newChartVersion = semver.inc(currentValue, bumpVersion as ReleaseType); + newChartVersion = semver.inc(currentValue, bumpVersion); if (!newChartVersion) { throw new Error('semver inc failed'); } diff --git a/lib/modules/manager/maven/update.ts b/lib/modules/manager/maven/update.ts index c76169b2cf..390979fcac 100644 --- a/lib/modules/manager/maven/update.ts +++ b/lib/modules/manager/maven/update.ts @@ -56,7 +56,7 @@ export function updateDependency({ export function bumpPackageVersion( content: string, currentValue: string | undefined, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): BumpPackageVersionResult { logger.debug( { bumpVersion, currentValue }, @@ -83,7 +83,7 @@ export function bumpPackageVersion( const startTagPosition = versionNode.startTagPosition; const versionPosition = content.indexOf(versionNode.val, startTagPosition); - const newPomVersion = semver.inc(currentValue, bumpVersion as ReleaseType); + const newPomVersion = semver.inc(currentValue, bumpVersion); if (!newPomVersion) { throw new Error('semver inc failed'); } diff --git a/lib/modules/manager/npm/update/package-version/index.ts b/lib/modules/manager/npm/update/package-version/index.ts index 83dc96007e..ba5022fb0a 100644 --- a/lib/modules/manager/npm/update/package-version/index.ts +++ b/lib/modules/manager/npm/update/package-version/index.ts @@ -6,7 +6,7 @@ import type { BumpPackageVersionResult } from '../../../types'; export function bumpPackageVersion( content: string, currentValue: string, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): BumpPackageVersionResult { logger.debug( { bumpVersion, currentValue }, @@ -29,7 +29,7 @@ export function bumpPackageVersion( return { bumpedContent }; } } else { - newPjVersion = semver.inc(currentValue, bumpVersion as ReleaseType); + newPjVersion = semver.inc(currentValue, bumpVersion); } // TODO: fix types (#7154) logger.debug(`newPjVersion: ${newPjVersion!}`); diff --git a/lib/modules/manager/nuget/update.ts b/lib/modules/manager/nuget/update.ts index ad258f2ff3..232c1ab850 100644 --- a/lib/modules/manager/nuget/update.ts +++ b/lib/modules/manager/nuget/update.ts @@ -7,7 +7,7 @@ import type { BumpPackageVersionResult } from '../types'; export function bumpPackageVersion( content: string, currentValue: string | undefined, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): BumpPackageVersionResult { logger.debug( { bumpVersion, currentValue }, @@ -38,7 +38,7 @@ export function bumpPackageVersion( startTagPosition ); - const newProjVersion = semver.inc(currentValue, bumpVersion as ReleaseType); + const newProjVersion = semver.inc(currentValue, bumpVersion); if (!newProjVersion) { throw new Error('semver inc failed'); } diff --git a/lib/modules/manager/sbt/update.ts b/lib/modules/manager/sbt/update.ts index 91ab867c39..0fa3ecfe75 100644 --- a/lib/modules/manager/sbt/update.ts +++ b/lib/modules/manager/sbt/update.ts @@ -6,14 +6,14 @@ import type { BumpPackageVersionResult } from '../types'; export function bumpPackageVersion( content: string, currentValue: string, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): BumpPackageVersionResult { logger.debug( { bumpVersion, currentValue }, 'Checking if we should bump build.sbt version' ); let bumpedContent = content; - const bumpedVersion = semver.inc(currentValue, bumpVersion as ReleaseType); + const bumpedVersion = semver.inc(currentValue, bumpVersion); if (!bumpedVersion) { logger.warn('Version incremental failed'); return { bumpedContent }; diff --git a/lib/modules/manager/types.ts b/lib/modules/manager/types.ts index 15a6fd9742..9312bcd606 100644 --- a/lib/modules/manager/types.ts +++ b/lib/modules/manager/types.ts @@ -117,7 +117,7 @@ export interface PackageDependency<T = Record<string, any>> versioning?: string; dataType?: string; enabled?: boolean; - bumpVersion?: ReleaseType | string; + bumpVersion?: ReleaseType; npmPackageAlias?: boolean; packageFileVersion?: string; gitRef?: boolean; @@ -238,7 +238,7 @@ export interface ManagerApi extends ModuleApi { bumpPackageVersion?( content: string, currentValue: string, - bumpVersion: ReleaseType | string + bumpVersion: ReleaseType ): Result<BumpPackageVersionResult>; detectGlobalConfig?(): Result<GlobalManagerConfig>; -- GitLab