From 6ae4a55bd3777698f89a0e582cec5def2243e582 Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Fri, 15 Jul 2022 12:46:02 +0200 Subject: [PATCH] docs(best practices): avoid boolean instead use is functions (#16573) * docs(best practices): avoid boolean instead use is functions * Update docs/development/best-practices.md Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Michael Kriese <michael.kriese@visualon.de> --- docs/development/best-practices.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/development/best-practices.md b/docs/development/best-practices.md index 32443b35f5..6da69b6236 100644 --- a/docs/development/best-practices.md +++ b/docs/development/best-practices.md @@ -11,7 +11,8 @@ Follow these best practices when you're working on our code. - Always add unit tests for full code coverage - Only use `istanbul` comments for unreachable code coverage that is needed for `codecov` completion - Use descriptive `istanbul` comments -- Avoid cast or prefer `x as T` instead of `<T>x` cast. +- Avoid cast or prefer `x as T` instead of `<T>x` cast +- Avoid `Boolean` instead use `is` functions from `@sindresorhus/is` package, for example: `is.string` ```ts // istanbul ignore next: can never happen -- GitLab