From 7a6bcfcf0ee95bfc0134f2e89cb80b4833c95719 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Thu, 3 May 2018 18:35:57 +0200 Subject: [PATCH] fix: handle undefined depType in onboarding PR --- lib/workers/repository/onboarding/pr/pr-list.js | 6 +++++- .../onboarding/pr/__snapshots__/pr-list.spec.js.snap | 2 +- test/workers/repository/onboarding/pr/pr-list.spec.js | 1 - 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/workers/repository/onboarding/pr/pr-list.js b/lib/workers/repository/onboarding/pr/pr-list.js index 492211d84c..5758004cd5 100644 --- a/lib/workers/repository/onboarding/pr/pr-list.js +++ b/lib/workers/repository/onboarding/pr/pr-list.js @@ -38,7 +38,11 @@ function getPrList(config) { } else { prDesc += upgrade.depName.replace(prTitleRe, '@​$1'); } - prDesc += ` in \`${upgrade.depType}\` `; + if (upgrade.depType) { + prDesc += ` in \`${upgrade.depType}\` `; + } else { + prDesc += ' '; + } if (!upgrade.isPin) { prDesc += `from \`${upgrade.currentVersion}\` `; } diff --git a/test/workers/repository/onboarding/pr/__snapshots__/pr-list.spec.js.snap b/test/workers/repository/onboarding/pr/__snapshots__/pr-list.spec.js.snap index d7559ff1f5..470f56cd5c 100644 --- a/test/workers/repository/onboarding/pr/__snapshots__/pr-list.spec.js.snap +++ b/test/workers/repository/onboarding/pr/__snapshots__/pr-list.spec.js.snap @@ -10,7 +10,7 @@ With your current configuration, Renovate will create 2 Pull Requests: - Branch name: \`renovate/pin-dependencies\` - Pins [a](https://a) in \`devDependencies\` to \`1.1.0\` - - Pins b in \`devDependencies\` to \`1.5.3\` + - Pins b to \`1.5.3\` 2. **Update a to v2** diff --git a/test/workers/repository/onboarding/pr/pr-list.spec.js b/test/workers/repository/onboarding/pr/pr-list.spec.js index 90f3c38f41..8535b18df6 100644 --- a/test/workers/repository/onboarding/pr/pr-list.spec.js +++ b/test/workers/repository/onboarding/pr/pr-list.spec.js @@ -45,7 +45,6 @@ describe('workers/repository/onboarding/pr/pr-list', () => { { isPin: true, depName: 'b', - depType: 'devDependencies', newVersion: '1.5.3', }, ], -- GitLab