From 7b6d2d9c9987f40be4faf4465042ba8c22c6bd9c Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Thu, 23 Apr 2020 18:35:46 +0200
Subject: [PATCH] fix(pr): wider try/catch on changelog versioning
---
lib/workers/pr/changelog/index.ts | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/lib/workers/pr/changelog/index.ts b/lib/workers/pr/changelog/index.ts
index 76b3f4083f..0cb11e95d1 100644
--- a/lib/workers/pr/changelog/index.ts
+++ b/lib/workers/pr/changelog/index.ts
@@ -11,21 +11,21 @@ export async function getChangeLogJSON(
args: BranchUpgradeConfig
): Promise<ChangeLogResult | null> {
const { sourceUrl, versioning, fromVersion, toVersion } = args;
- if (!sourceUrl) {
- return null;
- }
- const version = allVersioning.get(versioning);
- if (!fromVersion || version.equals(fromVersion, toVersion)) {
- return null;
- }
+ try {
+ if (!sourceUrl) {
+ return null;
+ }
+ const version = allVersioning.get(versioning);
+ if (!fromVersion || version.equals(fromVersion, toVersion)) {
+ return null;
+ }
- const releases = args.releases || (await getInRangeReleases(args));
+ const releases = args.releases || (await getInRangeReleases(args));
- try {
const res = await sourceGithub.getChangeLogJSON({ ...args, releases });
return res;
} catch (err) /* istanbul ignore next */ {
- logger.error({ err }, 'getChangeLogJSON error');
+ logger.error({ args, err }, 'getChangeLogJSON error');
return null;
}
}
--
GitLab