From 85117fd0cc9d33cdf9e37fb61e76ad6bfbc4918a Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Wed, 6 Mar 2019 09:49:04 +0100 Subject: [PATCH] refactor(orb): better logging on errors --- lib/datasource/orb/index.js | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/datasource/orb/index.js b/lib/datasource/orb/index.js index b183b3331d..c0a43fb67f 100644 --- a/lib/datasource/orb/index.js +++ b/lib/datasource/orb/index.js @@ -53,17 +53,12 @@ async function getPkgReleases({ lookupName }) { await renovateCache.set(cacheNamespace, cacheKey, dep, cacheMinutes); return dep; } catch (err) /* istanbul ignore next */ { + logger.debug({ err }, 'CircleCI Orb lookup error'); if (err.statusCode === 404 || err.code === 'ENOTFOUND') { logger.info({ lookupName }, `CircleCI Orb lookup failure: not found`); - logger.debug({ - err, - }); return null; } - logger.warn( - { err, lookupName }, - 'CircleCI Orb lookup failure: Unknown error' - ); + logger.warn({ lookupName }, 'CircleCI Orb lookup failure: Unknown error'); return null; } } -- GitLab