From 8c27d6fb23c7b782f0a020a60ef31ce7d705e4c2 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Tue, 25 Sep 2018 12:30:44 +0200 Subject: [PATCH] tests: drop fatal test and ignore --- lib/logger/pretty-stdout.js | 2 ++ lib/workers/global/index.js | 2 +- test/workers/global/index.spec.js | 8 -------- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/lib/logger/pretty-stdout.js b/lib/logger/pretty-stdout.js index 819e5bb544..a3b5db5639 100644 --- a/lib/logger/pretty-stdout.js +++ b/lib/logger/pretty-stdout.js @@ -75,6 +75,7 @@ function getDetails(rec) { .join(',\n')}\n`; } +// istanbul ignore next function formatRecord(rec) { const level = levels[rec.level]; const msg = `${indent(rec.msg)}`; @@ -91,6 +92,7 @@ function RenovateStream() { util.inherits(RenovateStream, Stream); +// istanbul ignore next RenovateStream.prototype.write = function write(data) { this.emit('data', formatRecord(data)); return true; diff --git a/lib/workers/global/index.js b/lib/workers/global/index.js index 40561a559d..738c935dd7 100644 --- a/lib/workers/global/index.js +++ b/lib/workers/global/index.js @@ -52,7 +52,7 @@ async function start() { } logger.setMeta({}); logger.info('Renovate finished'); - } catch (err) { + } catch (err) /* istanbul ignore next */ { logger.fatal({ err }, `Renovate fatal error: ${err.message}`); } } diff --git a/test/workers/global/index.spec.js b/test/workers/global/index.spec.js index 1b6cf9d380..39275c3b8c 100644 --- a/test/workers/global/index.spec.js +++ b/test/workers/global/index.spec.js @@ -32,12 +32,4 @@ describe('lib/workers/global', () => { expect(configParser.parseConfigs.mock.calls.length).toBe(1); expect(repositoryWorker.renovateRepository.mock.calls.length).toBe(2); }); - it('catches errors', async () => { - configParser.parseConfigs.mockImplementationOnce(() => { - throw new Error( - 'This fatal error is thrown for testing purposes and can be ignored' - ); - }); - await globalWorker.start(); - }); }); -- GitLab