From 97160c5710e530499d2eba30664fdae846b12cb2 Mon Sep 17 00:00:00 2001 From: Rhys Arkins <rhys@arkins.net> Date: Sat, 18 Apr 2020 22:42:34 +0200 Subject: [PATCH] refactor(mix): use autoReplace --- lib/manager/mix/index.ts | 1 - lib/manager/mix/update.spec.ts | 50 ---------------------------------- lib/manager/mix/update.ts | 26 ------------------ 3 files changed, 77 deletions(-) delete mode 100644 lib/manager/mix/update.spec.ts delete mode 100644 lib/manager/mix/update.ts diff --git a/lib/manager/mix/index.ts b/lib/manager/mix/index.ts index e47cac35e2..2f59d3edf2 100644 --- a/lib/manager/mix/index.ts +++ b/lib/manager/mix/index.ts @@ -2,7 +2,6 @@ import { LANGUAGE_ELIXIR } from '../../constants/languages'; import * as hexVersioning from '../../versioning/hex'; export { extractPackageFile } from './extract'; -export { updateDependency } from './update'; export { updateArtifacts } from './artifacts'; export const language = LANGUAGE_ELIXIR; diff --git a/lib/manager/mix/update.spec.ts b/lib/manager/mix/update.spec.ts deleted file mode 100644 index 12885902a8..0000000000 --- a/lib/manager/mix/update.spec.ts +++ /dev/null @@ -1,50 +0,0 @@ -import fs from 'fs-extra'; -import path from 'path'; -import { updateDependency } from '.'; - -const sample = fs.readFileSync( - path.resolve(__dirname, './__fixtures__/mix.exs'), - 'utf-8' -); - -describe('lib/manager/mix/update', () => { - describe('updateDependency', () => { - it('replaces existing value', () => { - const upgrade = { - depName: 'postgrex', - managerData: { lineNumber: 18 }, - newValue: '~> 0.8.2', - }; - const res = updateDependency({ fileContent: sample, upgrade }); - expect(res).not.toEqual(sample); - expect(res.includes(upgrade.newValue)).toBe(true); - }); - it('return the same', () => { - const upgrade = { - depName: 'postgrex', - managerData: { lineNumber: 18 }, - newValue: '~> 0.8.1', - }; - const res = updateDependency({ fileContent: sample, upgrade }); - expect(res).toEqual(sample); - }); - it('returns null if wrong line', () => { - const upgrade = { - depName: 'postgrex', - managerData: { lineNumber: 19 }, - newValue: '~> 0.8.2', - }; - const res = updateDependency({ fileContent: sample, upgrade }); - expect(res).toBeNull(); - }); - it('returns null for unsupported depType', () => { - const upgrade = { - depName: 'cowboy', - managerData: { lineNumber: 19 }, - newValue: '~> 0.8.2', - }; - const res = updateDependency({ fileContent: sample, upgrade }); - expect(res).toBeNull(); - }); - }); -}); diff --git a/lib/manager/mix/update.ts b/lib/manager/mix/update.ts deleted file mode 100644 index 6a46b11149..0000000000 --- a/lib/manager/mix/update.ts +++ /dev/null @@ -1,26 +0,0 @@ -import { logger } from '../../logger'; -import { UpdateDependencyConfig } from '../common'; - -export function updateDependency({ - fileContent, - upgrade, -}: UpdateDependencyConfig): string | null { - logger.debug(`mix.updateDependency: ${upgrade.newValue}`); - - const lines = fileContent.split('\n'); - const lineToChange = lines[upgrade.managerData.lineNumber]; - - if (!lineToChange.includes(upgrade.depName)) { - return null; - } - - const newLine = lineToChange.replace(/"(.*?)"/, `"${upgrade.newValue}"`); - - if (newLine === lineToChange) { - logger.debug('No changes necessary'); - return fileContent; - } - - lines[upgrade.managerData.lineNumber] = newLine; - return lines.join('\n'); -} -- GitLab