From 9732f3c7178267b38e0219cc3e6a19c6151dcfd2 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@keylocation.sg>
Date: Fri, 20 Oct 2017 06:04:46 +0200
Subject: [PATCH] refactor: log assignees and reviewers success after
completion (#999)
---
lib/workers/pr/index.js | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/lib/workers/pr/index.js b/lib/workers/pr/index.js
index 028d688da1..8cf61a62be 100644
--- a/lib/workers/pr/index.js
+++ b/lib/workers/pr/index.js
@@ -197,27 +197,33 @@ async function ensurePr(prConfig) {
async function addAssigneesReviewers(config, pr) {
const { logger } = config;
if (config.assignees.length > 0) {
- logger.debug({ assignees: config.assignees }, 'Adding assignees');
try {
const assignees = config.assignees.map(
assignee =>
assignee.length && assignee[0] === '@' ? assignee.slice(1) : assignee
);
await config.api.addAssignees(pr.number, assignees);
+ logger.info({ assignees: config.assignees }, 'Added assignees');
} catch (err) {
- logger.warn({ err }, 'Failed to add assignees');
+ logger.info(
+ { assignees: config.assignees, err },
+ 'Failed to add assignees'
+ );
}
}
if (config.reviewers.length > 0) {
- logger.info({ reviewers: config.reviewers }, 'Adding reviewers');
try {
const reviewers = config.reviewers.map(
reviewer =>
reviewer.length && reviewer[0] === '@' ? reviewer.slice(1) : reviewer
);
await config.api.addReviewers(pr.number, reviewers);
+ logger.info({ reviewers: config.reviewers }, 'Added reviewers');
} catch (err) {
- logger.warn({ err }, 'Failed to add reviewers');
+ logger.info(
+ { assignees: config.assignees, err },
+ 'Failed to add reviewers'
+ );
}
}
}
--
GitLab