From 98bc6a809e173ae888aa84b5240682adbc477b8a Mon Sep 17 00:00:00 2001 From: Sergei Zharinov <zharinov@users.noreply.github.com> Date: Mon, 16 Nov 2020 17:46:23 +0400 Subject: [PATCH] feat(sbt): Group dependencies by their variable names (#7410) --- lib/manager/sbt/__snapshots__/extract.spec.ts.snap | 5 +++++ lib/manager/sbt/extract.ts | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/lib/manager/sbt/__snapshots__/extract.spec.ts.snap b/lib/manager/sbt/__snapshots__/extract.spec.ts.snap index f55954f2b1..42e926cd86 100644 --- a/lib/manager/sbt/__snapshots__/extract.spec.ts.snap +++ b/lib/manager/sbt/__snapshots__/extract.spec.ts.snap @@ -26,6 +26,7 @@ Object { "currentValue": "1.2.3", "datasource": "sbt-package", "depName": "com.abc:abc", + "groupName": "abcVersion for com.abc", "lookupName": "com.abc:abc", "registryUrls": Array [ "https://repo.maven.apache.org/maven2", @@ -61,6 +62,7 @@ Object { "currentValue": "1.2.3", "datasource": "sbt-package", "depName": "com.abc:abc", + "groupName": "abcVersion for com.abc", "lookupName": "com.abc:abc", "registryUrls": Array [ "https://repo.maven.apache.org/maven2", @@ -208,6 +210,7 @@ Object { "datasource": "sbt-package", "depName": "org.example:grault", "depType": "Test", + "groupName": "versionExample for org.example", "lookupName": "org.example:grault", "registryUrls": Array [ "https://repo.maven.apache.org/maven2", @@ -345,6 +348,7 @@ Object { "datasource": "sbt-package", "depName": "org.example:grault", "depType": "Test", + "groupName": "versionExample for org.example", "lookupName": "org.example:grault", "registryUrls": Array [ "https://repo.maven.apache.org/maven2", @@ -433,6 +437,7 @@ Object { "datasource": "sbt-plugin", "depName": "com.github.gseitz:sbt-release", "depType": "plugin", + "groupName": "sbtReleaseVersion for com.github.gseitz", "lookupName": "com.github.gseitz:sbt-release", "registryUrls": Array [ "https://repo.maven.apache.org/maven2", diff --git a/lib/manager/sbt/extract.ts b/lib/manager/sbt/extract.ts index 90e2ff7589..d00ec7e88e 100644 --- a/lib/manager/sbt/extract.ts +++ b/lib/manager/sbt/extract.ts @@ -176,6 +176,10 @@ function parseDepExpr( currentValue, }; + if (variables[rawVersion]) { + result.groupName = `${rawVersion} for ${groupId}`; + } + if (depType) { result.depType = depType; } -- GitLab